[Python-checkins] bpo-27635: Fix pickle documentation about `__new__` not being called. (GH-19269)

Miss Islington (bot) webhook-mailer at python.org
Sat Apr 18 14:14:45 EDT 2020


https://github.com/python/cpython/commit/0abb548cc7b239fbe426ca9e00968130e53ffc98
commit: 0abb548cc7b239fbe426ca9e00968130e53ffc98
branch: 3.7
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2020-04-18T11:14:41-07:00
summary:

bpo-27635: Fix pickle documentation about `__new__` not being called. (GH-19269)


Automerge-Triggered-By: @pitrou
(cherry picked from commit 482259d0dcf27714a84cf56b93977320bea7e093)

Co-authored-by: Furkan Önder <furkantahaonder at gmail.com>

files:
A Misc/NEWS.d/next/Documentation/2020-04-01-00-27-03.bpo-27635.VwxUty.rst
M Doc/library/pickle.rst

diff --git a/Doc/library/pickle.rst b/Doc/library/pickle.rst
index f741976c93064..d638944756e7a 100644
--- a/Doc/library/pickle.rst
+++ b/Doc/library/pickle.rst
@@ -562,9 +562,9 @@ the methods :meth:`__getstate__` and :meth:`__setstate__`.
    At unpickling time, some methods like :meth:`__getattr__`,
    :meth:`__getattribute__`, or :meth:`__setattr__` may be called upon the
    instance.  In case those methods rely on some internal invariant being
-   true, the type should implement :meth:`__getnewargs__` or
-   :meth:`__getnewargs_ex__` to establish such an invariant; otherwise,
-   neither :meth:`__new__` nor :meth:`__init__` will be called.
+   true, the type should implement :meth:`__new__` to establish such an
+   invariant, as :meth:`__init__` is not called when unpickling an
+   instance.
 
 .. index:: pair: copy; protocol
 
diff --git a/Misc/NEWS.d/next/Documentation/2020-04-01-00-27-03.bpo-27635.VwxUty.rst b/Misc/NEWS.d/next/Documentation/2020-04-01-00-27-03.bpo-27635.VwxUty.rst
new file mode 100644
index 0000000000000..24f640bd4ef5f
--- /dev/null
+++ b/Misc/NEWS.d/next/Documentation/2020-04-01-00-27-03.bpo-27635.VwxUty.rst
@@ -0,0 +1,2 @@
+The pickle documentation incorrectly claimed that ``__new__`` isn't called by
+default when unpickling.



More information about the Python-checkins mailing list