[Python-checkins] bpo-35967: Skip test with `uname -p` on Android (GH-19577)
Chih-Hsuan Yen
webhook-mailer at python.org
Sat Apr 18 10:20:58 EDT 2020
https://github.com/python/cpython/commit/fb940408cea1fb34fed1418832f240f886dadf57
commit: fb940408cea1fb34fed1418832f240f886dadf57
branch: master
author: Chih-Hsuan Yen <yan12125 at gmail.com>
committer: GitHub <noreply at github.com>
date: 2020-04-18T07:20:54-07:00
summary:
bpo-35967: Skip test with `uname -p` on Android (GH-19577)
The uname binary on Android does not support -p [1]. Here is a sample
log:
```
0:06:03 load avg: 0.56 [254/421/8] test_platform failed -- running: test_asyncio (5 min 53 sec)
uname: Unknown option p (see "uname --help")
test test_platform failed -- Traceback (most recent call last):
File "/data/local/tmp/lib/python3.9/test/test_platform.py", line 170, in test_uname_processor
proc_res = subprocess.check_output(['uname', '-p'], text=True).strip()
File "/data/local/tmp/lib/python3.9/subprocess.py", line 420, in check_output
return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
File "/data/local/tmp/lib/python3.9/subprocess.py", line 524, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['uname', '-p']' returned non-zero exit status 1.
```
[1] https://android.googlesource.com/platform/external/toybox/+/refs/heads/master/toys/posix/uname.c
Automerge-Triggered-By: @jaraco
files:
M Lib/test/test_platform.py
diff --git a/Lib/test/test_platform.py b/Lib/test/test_platform.py
index 855304a68c204..998f1e0dc315a 100644
--- a/Lib/test/test_platform.py
+++ b/Lib/test/test_platform.py
@@ -167,8 +167,11 @@ def test_uname_processor(self):
On some systems, the processor must match the output
of 'uname -p'. See Issue 35967 for rationale.
"""
- proc_res = subprocess.check_output(['uname', '-p'], text=True).strip()
- expect = platform._unknown_as_blank(proc_res)
+ try:
+ proc_res = subprocess.check_output(['uname', '-p'], text=True).strip()
+ expect = platform._unknown_as_blank(proc_res)
+ except (OSError, subprocess.CalledProcessError):
+ expect = ''
self.assertEqual(platform.uname().processor, expect)
@unittest.skipUnless(sys.platform.startswith('win'), "windows only test")
More information about the Python-checkins
mailing list