[Python-checkins] asyncio: PendingDeprecationWarning -> DeprecationWarning (GH-12494)
Miss Islington (bot)
webhook-mailer at python.org
Fri Mar 22 07:07:37 EDT 2019
https://github.com/python/cpython/commit/c5c6cdada3d41148bdeeacfe7528327b481c5d18
commit: c5c6cdada3d41148bdeeacfe7528327b481c5d18
branch: master
author: Inada Naoki <songofacandy at gmail.com>
committer: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
date: 2019-03-22T04:07:32-07:00
summary:
asyncio: PendingDeprecationWarning -> DeprecationWarning (GH-12494)
`Task.current_task()` and `Task.all_tasks()` will be removed in 3.9.
files:
M Lib/asyncio/tasks.py
M Lib/test/test_asyncio/test_tasks.py
M Modules/_asynciomodule.c
diff --git a/Lib/asyncio/tasks.py b/Lib/asyncio/tasks.py
index 15422da1b3b2..d8508376d92a 100644
--- a/Lib/asyncio/tasks.py
+++ b/Lib/asyncio/tasks.py
@@ -97,7 +97,7 @@ def current_task(cls, loop=None):
"""
warnings.warn("Task.current_task() is deprecated, "
"use asyncio.current_task() instead",
- PendingDeprecationWarning,
+ DeprecationWarning,
stacklevel=2)
if loop is None:
loop = events.get_event_loop()
@@ -111,7 +111,7 @@ def all_tasks(cls, loop=None):
"""
warnings.warn("Task.all_tasks() is deprecated, "
"use asyncio.all_tasks() instead",
- PendingDeprecationWarning,
+ DeprecationWarning,
stacklevel=2)
return _all_tasks_compat(loop)
diff --git a/Lib/test/test_asyncio/test_tasks.py b/Lib/test/test_asyncio/test_tasks.py
index 22f14f87624e..1cdff528def4 100644
--- a/Lib/test/test_asyncio/test_tasks.py
+++ b/Lib/test/test_asyncio/test_tasks.py
@@ -1634,26 +1634,26 @@ def coro():
def test_current_task_deprecated(self):
Task = self.__class__.Task
- with self.assertWarns(PendingDeprecationWarning):
+ with self.assertWarns(DeprecationWarning):
self.assertIsNone(Task.current_task(loop=self.loop))
async def coro(loop):
- with self.assertWarns(PendingDeprecationWarning):
+ with self.assertWarns(DeprecationWarning):
self.assertIs(Task.current_task(loop=loop), task)
# See http://bugs.python.org/issue29271 for details:
asyncio.set_event_loop(loop)
try:
- with self.assertWarns(PendingDeprecationWarning):
+ with self.assertWarns(DeprecationWarning):
self.assertIs(Task.current_task(None), task)
- with self.assertWarns(PendingDeprecationWarning):
+ with self.assertWarns(DeprecationWarning):
self.assertIs(Task.current_task(), task)
finally:
asyncio.set_event_loop(None)
task = self.new_task(self.loop, coro(self.loop))
self.loop.run_until_complete(task)
- with self.assertWarns(PendingDeprecationWarning):
+ with self.assertWarns(DeprecationWarning):
self.assertIsNone(Task.current_task(loop=self.loop))
def test_current_task(self):
@@ -1982,7 +1982,7 @@ def test_all_tasks_deprecated(self):
Task = self.__class__.Task
async def coro():
- with self.assertWarns(PendingDeprecationWarning):
+ with self.assertWarns(DeprecationWarning):
assert Task.all_tasks(self.loop) == {t}
t = self.new_task(self.loop, coro())
@@ -2012,9 +2012,9 @@ def kill_me(loop):
# See http://bugs.python.org/issue29271 for details:
asyncio.set_event_loop(self.loop)
try:
- with self.assertWarns(PendingDeprecationWarning):
+ with self.assertWarns(DeprecationWarning):
self.assertEqual(Task.all_tasks(), {task})
- with self.assertWarns(PendingDeprecationWarning):
+ with self.assertWarns(DeprecationWarning):
self.assertEqual(Task.all_tasks(None), {task})
finally:
asyncio.set_event_loop(None)
@@ -2692,7 +2692,7 @@ def done(self):
self.assertEqual(asyncio.all_tasks(loop), set())
self._register_task(task)
self.assertEqual(asyncio.all_tasks(loop), set())
- with self.assertWarns(PendingDeprecationWarning):
+ with self.assertWarns(DeprecationWarning):
self.assertEqual(asyncio.Task.all_tasks(loop), {task})
self._unregister_task(task)
diff --git a/Modules/_asynciomodule.c b/Modules/_asynciomodule.c
index 7637cb75d63f..f9037c279ac9 100644
--- a/Modules/_asynciomodule.c
+++ b/Modules/_asynciomodule.c
@@ -2088,7 +2088,7 @@ _asyncio_Task_current_task_impl(PyTypeObject *type, PyObject *loop)
PyObject *ret;
PyObject *current_task_func;
- if (PyErr_WarnEx(PyExc_PendingDeprecationWarning,
+ if (PyErr_WarnEx(PyExc_DeprecationWarning,
"Task.current_task() is deprecated, " \
"use asyncio.current_task() instead",
1) < 0) {
@@ -2136,7 +2136,7 @@ _asyncio_Task_all_tasks_impl(PyTypeObject *type, PyObject *loop)
PyObject *res;
PyObject *all_tasks_func;
- if (PyErr_WarnEx(PyExc_PendingDeprecationWarning,
+ if (PyErr_WarnEx(PyExc_DeprecationWarning,
"Task.all_tasks() is deprecated, " \
"use asyncio.all_tasks() instead",
1) < 0) {
More information about the Python-checkins
mailing list