[Python-checkins] closes bpo-35184: Fix XML_POOR_ENTROPY option that breaks makesetup parsing of pyexpat line in Setup. (GH-13064)

[Benjamin Peterson]

https://github.com/python/cpython/commit/408a2ef1aceff1f4270c44552fa39ef93d9283e3
commit: 408a2ef1aceff1f4270c44552fa39ef93d9283e3
branch: master
author: aaronpaulhurst <aaronpaulhurst at gmail.com>
committer: Benjamin Peterson <benjamin at python.org>
date: 2019-06-10T18:54:24-07:00
summary:

closes bpo-35184: Fix XML_POOR_ENTROPY option that breaks makesetup parsing of pyexpat line in Setup. (GH-13064)

When the line is uncommented, the equals character causes it to be incorrectly interpreted
as a macro definition by makesetup.  This results in invalid Makefile output.

The expat code only requires XML_POOR_ENTROPY to be defined; the value is unnecessary.

files:
M Modules/Setup

diff --git a/Modules/Setup b/Modules/Setup
index e729ab883f41..ed5ee6c5033b 100644
--- a/Modules/Setup
+++ b/Modules/Setup
@@ -338,7 +338,7 @@ _symtable symtablemodule.c
 # Interface to the Expat XML parser
 # More information on Expat can be found at www.libexpat.org.
 #
-#pyexpat expat/xmlparse.c expat/xmlrole.c expat/xmltok.c pyexpat.c -I$(srcdir)/Modules/expat -DHAVE_EXPAT_CONFIG_H -DXML_POOR_ENTROPY=1 -DUSE_PYEXPAT_CAPI
+#pyexpat expat/xmlparse.c expat/xmlrole.c expat/xmltok.c pyexpat.c -I$(srcdir)/Modules/expat -DHAVE_EXPAT_CONFIG_H -DXML_POOR_ENTROPY -DUSE_PYEXPAT_CAPI
 
 # Hye-Shik Chang's CJKCodecs