[Python-checkins] bpo-34855: Fix EXTERNALS_DIR build variable for Windows (GH-11177)
Steve Dower
webhook-mailer at python.org
Wed Jan 9 19:19:32 EST 2019
https://github.com/python/cpython/commit/6aedfa6b9ac324587f64133c23757a66a8f355bb
commit: 6aedfa6b9ac324587f64133c23757a66a8f355bb
branch: master
author: antektek <45912913+antektek at users.noreply.github.com>
committer: Steve Dower <steve.dower at microsoft.com>
date: 2019-01-10T11:19:29+11:00
summary:
bpo-34855: Fix EXTERNALS_DIR build variable for Windows (GH-11177)
files:
M .azure-pipelines/windows-appx-test.yml
M .azure-pipelines/windows-steps.yml
M PCbuild/find_python.bat
diff --git a/.azure-pipelines/windows-appx-test.yml b/.azure-pipelines/windows-appx-test.yml
index 5f3fe6c94578..cad752b0a1e7 100644
--- a/.azure-pipelines/windows-appx-test.yml
+++ b/.azure-pipelines/windows-appx-test.yml
@@ -36,7 +36,7 @@ jobs:
Write-Host '##vso[task.setvariable variable=Py_IntDir]$(Build.BinariesDirectory)\obj'
# UNDONE: Do not build to a different directory because of broken tests
Write-Host '##vso[task.setvariable variable=Py_OutDir]$(Build.SourcesDirectory)\PCbuild'
- Write-Host '##vso[task.setvariable variable=EXTERNAL_DIR]$(Build.BinariesDirectory)\externals'
+ Write-Host '##vso[task.setvariable variable=EXTERNALS_DIR]$(Build.BinariesDirectory)\externals'
displayName: Update build locations
- script: PCbuild\build.bat -e $(buildOpt)
diff --git a/.azure-pipelines/windows-steps.yml b/.azure-pipelines/windows-steps.yml
index cba00158ad13..3651ae03bc1d 100644
--- a/.azure-pipelines/windows-steps.yml
+++ b/.azure-pipelines/windows-steps.yml
@@ -8,7 +8,7 @@ steps:
Write-Host '##vso[task.setvariable variable=Py_IntDir]$(Build.BinariesDirectory)\obj'
# UNDONE: Do not build to a different directory because of broken tests
Write-Host '##vso[task.setvariable variable=Py_OutDir]$(Build.SourcesDirectory)\PCbuild'
- Write-Host '##vso[task.setvariable variable=EXTERNAL_DIR]$(Build.BinariesDirectory)\externals'
+ Write-Host '##vso[task.setvariable variable=EXTERNALS_DIR]$(Build.BinariesDirectory)\externals'
displayName: Update build locations
- script: PCbuild\build.bat -e $(buildOpt)
diff --git a/PCbuild/find_python.bat b/PCbuild/find_python.bat
index d0778ddd7347..d5c787fd77aa 100644
--- a/PCbuild/find_python.bat
+++ b/PCbuild/find_python.bat
@@ -24,7 +24,7 @@
:begin_search
@set PYTHON=
- at set _Py_EXTERNALS_DIR=%EXTERNAL_DIR%
+ at set _Py_EXTERNALS_DIR=%EXTERNALS_DIR%
@if "%_Py_EXTERNALS_DIR%"=="" (set _Py_EXTERNALS_DIR=%~dp0\..\externals)
@rem If we have Python in externals, use that one
More information about the Python-checkins
mailing list