[Python-checkins] Do not retain references to processes and managers in TestSyncManagerTypes (GH-11801)

Miss Islington (bot) webhook-mailer at python.org
Sat Feb 9 12:26:20 EST 2019


https://github.com/python/cpython/commit/36ed5b3c4e565c1fdfe22e61b33613d98a61df7c
commit: 36ed5b3c4e565c1fdfe22e61b33613d98a61df7c
branch: 3.7
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2019-02-09T09:26:16-08:00
summary:

Do not retain references to processes and managers in TestSyncManagerTypes (GH-11801)


Keeping references to processes and managers between tests makes them count as dangling processes.
(cherry picked from commit 613f729e5ddd201765a9a04efc1c76decb3a19c4)

Co-authored-by: Pablo Galindo <Pablogsal at gmail.com>

files:
M Lib/test/_test_multiprocessing.py

diff --git a/Lib/test/_test_multiprocessing.py b/Lib/test/_test_multiprocessing.py
index c35b920758db..487ad4b4ec0d 100644
--- a/Lib/test/_test_multiprocessing.py
+++ b/Lib/test/_test_multiprocessing.py
@@ -4610,6 +4610,8 @@ def tearDown(self):
             self.proc.terminate()
             self.proc.join()
         self.manager.shutdown()
+        self.manager = None
+        self.proc = None
 
     @classmethod
     def setUpClass(cls):



More information about the Python-checkins mailing list