[Python-checkins] bpo-35518: Skip test that relies on a deceased network service. (GH-15349)
Miss Islington (bot)
webhook-mailer at python.org
Wed Aug 21 00:12:21 EDT 2019
https://github.com/python/cpython/commit/198a0d622a696a4c234aa7866d6c15e38839cc76
commit: 198a0d622a696a4c234aa7866d6c15e38839cc76
branch: 2.7
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2019-08-20T21:12:18-07:00
summary:
bpo-35518: Skip test that relies on a deceased network service. (GH-15349)
If this service had thoroughly vanished, we could just ignore the
test until someone gets around to either recreating such a service
or redesigning the test to somehow work locally. The
`support.transient_internet` mechanism catches the failure to
resolve the domain name, and skips the test.
But in fact the domain snakebite.net does still exist, as do its
nameservers -- and they can be quite slow to reply. As a result
this test can easily take 20-30s before it gets auto-skipped.
So, skip the test explicitly up front.
(cherry picked from commit 5b95a1507e349da5adae6d2ab57deac3bdd12f15)
Co-authored-by: Greg Price <gnprice at gmail.com>
files:
M Lib/test/test_timeout.py
diff --git a/Lib/test/test_timeout.py b/Lib/test/test_timeout.py
index bb9252d1a433..51690335b70e 100644
--- a/Lib/test/test_timeout.py
+++ b/Lib/test/test_timeout.py
@@ -106,6 +106,7 @@ def setUp(self):
def tearDown(self):
self.sock.close()
+ @unittest.skipIf(True, 'need to replace these hosts; see bpo-35518')
def testConnectTimeout(self):
# Choose a private address that is unlikely to exist to prevent
# failures due to the connect succeeding before the timeout.
More information about the Python-checkins
mailing list