[Python-checkins] bpo-35726: Add test for QueueHandler with multiple handlers (GH-11659)

Vinay Sajip webhook-mailer at python.org
Sun Apr 7 03:51:41 EDT 2019


https://github.com/python/cpython/commit/2dad96013ca24abdc5ba5a369ea42d70ff02487a
commit: 2dad96013ca24abdc5ba5a369ea42d70ff02487a
branch: master
author: Xtreak <tir.karthi at gmail.com>
committer: Vinay Sajip <vinay_sajip at yahoo.co.uk>
date: 2019-04-07T08:51:27+01:00
summary:

bpo-35726: Add test for QueueHandler with multiple handlers (GH-11659)

files:
M Lib/test/test_logging.py

diff --git a/Lib/test/test_logging.py b/Lib/test/test_logging.py
index b23ae24920b7..1805249e48bc 100644
--- a/Lib/test/test_logging.py
+++ b/Lib/test/test_logging.py
@@ -3505,6 +3505,19 @@ def test_queue_listener_with_StreamHandler(self):
         listener.stop()
         self.assertEqual(self.stream.getvalue().strip().count('Traceback'), 1)
 
+    @unittest.skipUnless(hasattr(logging.handlers, 'QueueListener'),
+                         'logging.handlers.QueueListener required for this test')
+    def test_queue_listener_with_multiple_handlers(self):
+        # Test that queue handler format doesn't affect other handler formats (bpo-35726).
+        self.que_hdlr.setFormatter(self.root_formatter)
+        self.que_logger.addHandler(self.root_hdlr)
+
+        listener = logging.handlers.QueueListener(self.queue, self.que_hdlr)
+        listener.start()
+        self.que_logger.error("error")
+        listener.stop()
+        self.assertEqual(self.stream.getvalue().strip(), "que -> ERROR: error")
+
 if hasattr(logging.handlers, 'QueueListener'):
     import multiprocessing
     from unittest.mock import patch



More information about the Python-checkins mailing list