[Python-checkins] Fix-up parenthesis, organization, and NULL check (GH-9297)
Raymond Hettinger
webhook-mailer at python.org
Fri Sep 14 04:00:16 EDT 2018
https://github.com/python/cpython/commit/00bc08ec11d99cc68c7d5dc790ad3e609982a9c7
commit: 00bc08ec11d99cc68c7d5dc790ad3e609982a9c7
branch: master
author: Raymond Hettinger <rhettinger at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2018-09-14T01:00:11-07:00
summary:
Fix-up parenthesis, organization, and NULL check (GH-9297)
files:
M Objects/longobject.c
diff --git a/Objects/longobject.c b/Objects/longobject.c
index 98ff9a8c265b..102093e19865 100644
--- a/Objects/longobject.c
+++ b/Objects/longobject.c
@@ -5280,14 +5280,19 @@ static PyObject *
int_as_integer_ratio_impl(PyObject *self)
/*[clinic end generated code: output=e60803ae1cc8621a input=55ce3058e15de393]*/
{
- if PyLong_CheckExact(self) {
+ PyObject *numerator;
+ PyObject *ratio_tuple;
+
+ if (PyLong_CheckExact(self)) {
return PyTuple_Pack(2, self, _PyLong_One);
- } else {
- PyObject *numerator = _PyLong_Copy(self);
- PyObject *ratio_tuple = PyTuple_Pack(2, numerator, _PyLong_One);
- Py_DECREF(numerator);
- return ratio_tuple;
}
+ numerator = _PyLong_Copy(self);
+ if (numerator == NULL) {
+ return NULL;
+ }
+ ratio_tuple = PyTuple_Pack(2, numerator, _PyLong_One);
+ Py_DECREF(numerator);
+ return ratio_tuple;
}
/*[clinic input]
More information about the Python-checkins
mailing list