[Python-checkins] Simplified implementation of _sre.ascii_iscased(). (GH-9097)

Serhiy Storchaka webhook-mailer at python.org
Wed Sep 12 08:49:16 EDT 2018


https://github.com/python/cpython/commit/7f0d59f3a83cf1a98398b8e5bdfb97c7a71216bd
commit: 7f0d59f3a83cf1a98398b8e5bdfb97c7a71216bd
branch: master
author: Sergey Fedoseev <fedoseev.sergey at gmail.com>
committer: Serhiy Storchaka <storchaka at gmail.com>
date: 2018-09-12T15:49:09+03:00
summary:

Simplified implementation of _sre.ascii_iscased(). (GH-9097)

files:
M Modules/_sre.c

diff --git a/Modules/_sre.c b/Modules/_sre.c
index 483cf5e9ff9c..c3509796f3a1 100644
--- a/Modules/_sre.c
+++ b/Modules/_sre.c
@@ -100,11 +100,6 @@ static unsigned int sre_lower_ascii(unsigned int ch)
     return ((ch) < 128 ? Py_TOLOWER(ch) : ch);
 }
 
-static unsigned int sre_upper_ascii(unsigned int ch)
-{
-    return ((ch) < 128 ? Py_TOUPPER(ch) : ch);
-}
-
 /* locale-specific character predicates */
 /* !(c & ~N) == (c < N+1) for any unsigned c, this avoids
  * warnings when c's type supports only numbers < N+1 */
@@ -293,7 +288,7 @@ _sre_ascii_iscased_impl(PyObject *module, int character)
 /*[clinic end generated code: output=4f454b630fbd19a2 input=9f0bd952812c7ed3]*/
 {
     unsigned int ch = (unsigned int)character;
-    return ch != sre_lower_ascii(ch) || ch != sre_upper_ascii(ch);
+    return ch < 128 && Py_ISALPHA(ch);
 }
 
 /*[clinic input]



More information about the Python-checkins mailing list