[Python-checkins] bpo-35031: Fix test_start_tls_server_1 on FreeBSD buildbots (GH-10011)

Miss Islington (bot) webhook-mailer at python.org
Mon Nov 12 20:24:44 EST 2018


https://github.com/python/cpython/commit/3f9fe53c98978955fea4e36456c784694e6458a8
commit: 3f9fe53c98978955fea4e36456c784694e6458a8
branch: 3.7
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2018-11-12T17:24:39-08:00
summary:

bpo-35031: Fix test_start_tls_server_1 on FreeBSD buildbots (GH-10011)


Some FreeBSD buildbots fail to run this test as the eof was not being received by the server if the size is not big enough. This behaviour only appears if the client is using TLS1.3.
(cherry picked from commit f6a47f3e316cede2a07a1f74a509f6d80ab8fef0)

Co-authored-by: Pablo Galindo <Pablogsal at gmail.com>

files:
M Lib/test/test_asyncio/test_sslproto.py

diff --git a/Lib/test/test_asyncio/test_sslproto.py b/Lib/test/test_asyncio/test_sslproto.py
index 46a1523ea1ec..44ae3b67e0bd 100644
--- a/Lib/test/test_asyncio/test_sslproto.py
+++ b/Lib/test/test_asyncio/test_sslproto.py
@@ -2,6 +2,7 @@
 
 import logging
 import socket
+import sys
 import unittest
 from unittest import mock
 try:
@@ -426,6 +427,12 @@ def test_start_tls_server_1(self):
 
         server_context = test_utils.simple_server_sslcontext()
         client_context = test_utils.simple_client_sslcontext()
+        if sys.platform.startswith('freebsd'):
+            # bpo-35031: Some FreeBSD buildbots fail to run this test
+            # as the eof was not being received by the server if the payload
+            # size is not big enough. This behaviour only appears if the
+            # client is using TLS1.3.
+            client_context.options |= ssl.OP_NO_TLSv1_3
 
         def client(sock, addr):
             sock.settimeout(self.TIMEOUT)



More information about the Python-checkins mailing list