[Python-checkins] bpo-33644: Fix signatures of tp_finalize handlers in testing code. (GH-7111)

Miss Islington (bot) webhook-mailer at python.org
Sat May 26 04:33:33 EDT 2018


https://github.com/python/cpython/commit/14d289be60a2ad4cb65990a63ed2e75e9a8cb3ec
commit: 14d289be60a2ad4cb65990a63ed2e75e9a8cb3ec
branch: 3.7
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2018-05-26T01:33:23-07:00
summary:

bpo-33644: Fix signatures of tp_finalize handlers in testing code. (GH-7111)

(cherry picked from commit 19de8b3dd742fb53681478ad4fff57ed7c37a953)

Co-authored-by: Serhiy Storchaka <storchaka at gmail.com>

files:
M Modules/_testmultiphase.c
M Modules/xxlimited.c

diff --git a/Modules/_testmultiphase.c b/Modules/_testmultiphase.c
index 8090a485f4a9..68404f2c6cdb 100644
--- a/Modules/_testmultiphase.c
+++ b/Modules/_testmultiphase.c
@@ -23,11 +23,10 @@ Example_traverse(ExampleObject *self, visitproc visit, void *arg)
     return 0;
 }
 
-static int
+static void
 Example_finalize(ExampleObject *self)
 {
     Py_CLEAR(self->x_attr);
-    return 0;
 }
 
 static PyObject *
diff --git a/Modules/xxlimited.c b/Modules/xxlimited.c
index 5041ac8284a3..5586989d039c 100644
--- a/Modules/xxlimited.c
+++ b/Modules/xxlimited.c
@@ -47,11 +47,10 @@ Xxo_traverse(XxoObject *self, visitproc visit, void *arg)
     return 0;
 }
 
-static int
+static void
 Xxo_finalize(XxoObject *self)
 {
     Py_CLEAR(self->x_attr);
-    return 0;
 }
 
 static PyObject *



More information about the Python-checkins mailing list