[Python-checkins] bpo-32262: Fix typo in f-string (GH-7016)
Christian Heimes
webhook-mailer at python.org
Sun May 20 13:57:16 EDT 2018
https://github.com/python/cpython/commit/d361e99868a9eaa7ffce9341e1207705dbb66b50
commit: d361e99868a9eaa7ffce9341e1207705dbb66b50
branch: master
author: Christian Heimes <christian at python.org>
committer: GitHub <noreply at github.com>
date: 2018-05-20T19:57:13+02:00
summary:
bpo-32262: Fix typo in f-string (GH-7016)
Fix typo from commit 6370f345e1d5829e1fba59cd695c8b82c5a8c620
Signed-off-by: Christian Heimes <christian at python.org>
<!--
Thanks for your contribution!
Please read this comment in its entirety. It's quite important.
# Pull Request title
It should be in the following format:
```
bpo-NNNN: Summary of the changes made
```
Where: bpo-NNNN refers to the issue number in the https://bugs.python.org.
Most PRs will require an issue number. Trivial changes, like fixing a typo, do not need an issue.
# Backport Pull Request title
If this is a backport PR (PR made against branches other than `master`),
please ensure that the PR title is in the following format:
```
[X.Y] <title from the original PR> (GH-NNNN)
```
Where: [X.Y] is the branch name, e.g. [3.6].
GH-NNNN refers to the PR number from `master`.
-->
<!-- issue-number: bpo-32262 -->
https://bugs.python.org/issue32262
<!-- /issue-number -->
files:
M Lib/asyncio/base_subprocess.py
M Lib/test/test_asyncio/test_subprocess.py
diff --git a/Lib/asyncio/base_subprocess.py b/Lib/asyncio/base_subprocess.py
index 7c17066f8bb2..b547c444ad5d 100644
--- a/Lib/asyncio/base_subprocess.py
+++ b/Lib/asyncio/base_subprocess.py
@@ -57,7 +57,7 @@ def __repr__(self):
if self._closed:
info.append('closed')
if self._pid is not None:
- info.append(f'pid={self.pid}')
+ info.append(f'pid={self._pid}')
if self._returncode is not None:
info.append(f'returncode={self._returncode}')
elif self._pid is not None:
diff --git a/Lib/test/test_asyncio/test_subprocess.py b/Lib/test/test_asyncio/test_subprocess.py
index 81b08d6c292a..428510f77161 100644
--- a/Lib/test/test_asyncio/test_subprocess.py
+++ b/Lib/test/test_asyncio/test_subprocess.py
@@ -29,6 +29,7 @@ def _start(self, *args, **kwargs):
self._proc.stdin = None
self._proc.stdout = None
self._proc.stderr = None
+ self._proc.pid = -1
class SubprocessTransportTests(test_utils.TestCase):
@@ -73,6 +74,29 @@ def test_proc_exited(self):
transport.close()
+ def test_subprocess_repr(self):
+ waiter = asyncio.Future(loop=self.loop)
+ transport, protocol = self.create_transport(waiter)
+ transport._process_exited(6)
+ self.loop.run_until_complete(waiter)
+
+ self.assertEqual(
+ repr(transport),
+ "<TestSubprocessTransport pid=-1 returncode=6>"
+ )
+ transport._returncode = None
+ self.assertEqual(
+ repr(transport),
+ "<TestSubprocessTransport pid=-1 running>"
+ )
+ transport._pid = None
+ transport._returncode = None
+ self.assertEqual(
+ repr(transport),
+ "<TestSubprocessTransport not started>"
+ )
+ transport.close()
+
class SubprocessMixin:
More information about the Python-checkins
mailing list