[Python-checkins] bpo-31044, test_posix: Reenable makedev() tests on FreeBSD (#7449)

Victor Stinner webhook-mailer at python.org
Wed Jun 6 09:28:57 EDT 2018


https://github.com/python/cpython/commit/b5d702e5e7291eed21666ed931da2a5e92c28a65
commit: b5d702e5e7291eed21666ed931da2a5e92c28a65
branch: master
author: Victor Stinner <vstinner at redhat.com>
committer: GitHub <noreply at github.com>
date: 2018-06-06T15:28:50+02:00
summary:

bpo-31044, test_posix: Reenable makedev() tests on FreeBSD (#7449)

The bug has been fixed 10 months ago:

* https://svnweb.freebsd.org/base?view=revision&revision=321920
* https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221048

files:
M Lib/test/test_posix.py

diff --git a/Lib/test/test_posix.py b/Lib/test/test_posix.py
index e54484ce7da2..4f6abc6f7d6f 100644
--- a/Lib/test/test_posix.py
+++ b/Lib/test/test_posix.py
@@ -615,11 +615,6 @@ def test_makedev(self):
         self.assertRaises(TypeError, posix.minor)
         self.assertRaises((ValueError, OverflowError), posix.minor, -1)
 
-        # FIXME: reenable these tests on FreeBSD with the kernel fix
-        if sys.platform.startswith('freebsd') and dev >= 0x1_0000_0000:
-            self.skipTest("bpo-31044: on FreeBSD CURRENT, minor() truncates "
-                          "64-bit dev to 32-bit")
-
         self.assertEqual(posix.makedev(major, minor), dev)
         self.assertRaises(TypeError, posix.makedev, float(major), minor)
         self.assertRaises(TypeError, posix.makedev, major, float(minor))



More information about the Python-checkins mailing list