[Python-checkins] [2.7] bpo-33760: Fix file leaks in test_io. (GH-7361). (GH-7373)

Ned Deily webhook-mailer at python.org
Sun Jun 3 23:38:00 EDT 2018


https://github.com/python/cpython/commit/b02ceb57d23c26aca6666b3a9f4c5b7d84d0ea0a
commit: b02ceb57d23c26aca6666b3a9f4c5b7d84d0ea0a
branch: 2.7
author: Serhiy Storchaka <storchaka at gmail.com>
committer: Ned Deily <nad at python.org>
date: 2018-06-03T23:37:57-04:00
summary:

[2.7] bpo-33760: Fix file leaks in test_io. (GH-7361). (GH-7373)

(cherry picked from commit e36837cb71032ccfa713e75623b314f091dc22bb)

Co-authored-by: Serhiy Storchaka <storchaka at gmail.com>

files:
M Lib/test/test_io.py

diff --git a/Lib/test/test_io.py b/Lib/test/test_io.py
index ddb318a61c86..a7257115fc90 100644
--- a/Lib/test/test_io.py
+++ b/Lib/test/test_io.py
@@ -1091,6 +1091,7 @@ def test_misbehaved_io_read(self):
     def test_garbage_collection(self):
         # C BufferedReader objects are collected.
         # The Python version has __del__, so it ends into gc.garbage instead
+        self.addCleanup(support.unlink, support.TESTFN)
         rawio = self.FileIO(support.TESTFN, "w+b")
         f = self.tp(rawio)
         f.f = f
@@ -1292,6 +1293,7 @@ def test_destructor(self):
 
     def test_truncate(self):
         # Truncate implicitly flushes the buffer.
+        self.addCleanup(support.unlink, support.TESTFN)
         with self.open(support.TESTFN, self.write_mode, buffering=0) as raw:
             bufio = self.tp(raw, 8)
             bufio.write(b"abcdef")
@@ -1398,6 +1400,7 @@ def test_garbage_collection(self):
         # C BufferedWriter objects are collected, and collecting them flushes
         # all data to disk.
         # The Python version has __del__, so it ends into gc.garbage instead
+        self.addCleanup(support.unlink, support.TESTFN)
         rawio = self.FileIO(support.TESTFN, "w+b")
         f = self.tp(rawio)
         f.write(b"123xxx")



More information about the Python-checkins mailing list