[Python-checkins] bpo-33760: Fix file leaks in test_io. (GH-7361) (GH-7372)

Ned Deily webhook-mailer at python.org
Sun Jun 3 23:31:54 EDT 2018


https://github.com/python/cpython/commit/d18b13d36a22f93050a9d7cdfce594002f69236f
commit: d18b13d36a22f93050a9d7cdfce594002f69236f
branch: 3.6
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: Ned Deily <nad at python.org>
date: 2018-06-03T23:31:51-04:00
summary:

bpo-33760: Fix file leaks in test_io. (GH-7361) (GH-7372)

(cherry picked from commit e36837cb71032ccfa713e75623b314f091dc22bb)

Co-authored-by: Serhiy Storchaka <storchaka at gmail.com>

files:
M Lib/test/test_io.py

diff --git a/Lib/test/test_io.py b/Lib/test/test_io.py
index 22f79d7b9575..0b5b033b5f88 100644
--- a/Lib/test/test_io.py
+++ b/Lib/test/test_io.py
@@ -1496,6 +1496,7 @@ def test_misbehaved_io_read(self):
     def test_garbage_collection(self):
         # C BufferedReader objects are collected.
         # The Python version has __del__, so it ends into gc.garbage instead
+        self.addCleanup(support.unlink, support.TESTFN)
         with support.check_warnings(('', ResourceWarning)):
             rawio = self.FileIO(support.TESTFN, "w+b")
             f = self.tp(rawio)
@@ -1698,6 +1699,7 @@ def test_destructor(self):
 
     def test_truncate(self):
         # Truncate implicitly flushes the buffer.
+        self.addCleanup(support.unlink, support.TESTFN)
         with self.open(support.TESTFN, self.write_mode, buffering=0) as raw:
             bufio = self.tp(raw, 8)
             bufio.write(b"abcdef")
@@ -1710,6 +1712,7 @@ def test_truncate_after_write(self):
         # Ensure that truncate preserves the file position after
         # writes longer than the buffer size.
         # Issue: https://bugs.python.org/issue32228
+        self.addCleanup(support.unlink, support.TESTFN)
         with self.open(support.TESTFN, "wb") as f:
             # Fill with some buffer
             f.write(b'\x00' * 10000)
@@ -1820,6 +1823,7 @@ def test_garbage_collection(self):
         # C BufferedWriter objects are collected, and collecting them flushes
         # all data to disk.
         # The Python version has __del__, so it ends into gc.garbage instead
+        self.addCleanup(support.unlink, support.TESTFN)
         with support.check_warnings(('', ResourceWarning)):
             rawio = self.FileIO(support.TESTFN, "w+b")
             f = self.tp(rawio)



More information about the Python-checkins mailing list