[Python-checkins] bpo-33723: Fix test_time.test_process_time() (GH-8358) (GH-8362)

Victor Stinner webhook-mailer at python.org
Fri Jul 20 21:52:47 EDT 2018


https://github.com/python/cpython/commit/a7a6eac966dd52db1762c8f455c1e208df36feb4
commit: a7a6eac966dd52db1762c8f455c1e208df36feb4
branch: 3.7
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: Victor Stinner <vstinner at redhat.com>
date: 2018-07-21T03:52:44+02:00
summary:

bpo-33723: Fix test_time.test_process_time() (GH-8358) (GH-8362)

The test failed on my laptop because the busy loop took 15.9 ms
whereas the test expects at least 20 ms. Modify test_process_time()
as test_thread_time() has been modified recently: only require 15 ms
instead of 20 ms.
(cherry picked from commit e78dace8dcb23c371df19c9add65895adf436995)

Co-authored-by: Victor Stinner <vstinner at redhat.com>

files:
M Lib/test/test_time.py

diff --git a/Lib/test/test_time.py b/Lib/test/test_time.py
index 1ebe0cf5684c..cab437d44ad7 100644
--- a/Lib/test/test_time.py
+++ b/Lib/test/test_time.py
@@ -496,18 +496,23 @@ def test_process_time(self):
         # on Windows
         self.assertLess(stop - start, 0.020)
 
+        # bpo-33723: A busy loop of 100 ms should increase process_time()
+        # by at least 15 ms
+        min_time = 0.015
+        busy_time = 0.100
+
         # process_time() should include CPU time spent in any thread
         start = time.process_time()
-        busy_wait(0.100)
+        busy_wait(busy_time)
         stop = time.process_time()
-        self.assertGreaterEqual(stop - start, 0.020)  # machine busy?
+        self.assertGreaterEqual(stop - start, min_time)
 
-        t = threading.Thread(target=busy_wait, args=(0.100,))
+        t = threading.Thread(target=busy_wait, args=(busy_time,))
         start = time.process_time()
         t.start()
         t.join()
         stop = time.process_time()
-        self.assertGreaterEqual(stop - start, 0.020)  # machine busy?
+        self.assertGreaterEqual(stop - start, min_time)
 
         info = time.get_clock_info('process_time')
         self.assertTrue(info.monotonic)



More information about the Python-checkins mailing list