[Python-checkins] bpo-32360: unittest.util: Use Counter instead of custom count function (GH-4994)
INADA Naoki
webhook-mailer at python.org
Wed Jan 24 02:50:03 EST 2018
https://github.com/python/cpython/commit/018e1b7aad8d1a33ee14aae5c466d581d31e2369
commit: 018e1b7aad8d1a33ee14aae5c466d581d31e2369
branch: master
author: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) <srinivasreddy at users.noreply.github.com>
committer: INADA Naoki <methane at users.noreply.github.com>
date: 2018-01-24T16:49:58+09:00
summary:
bpo-32360: unittest.util: Use Counter instead of custom count function (GH-4994)
files:
M Lib/unittest/util.py
diff --git a/Lib/unittest/util.py b/Lib/unittest/util.py
index 45485dcb0df..050eaed0b3f 100644
--- a/Lib/unittest/util.py
+++ b/Lib/unittest/util.py
@@ -1,6 +1,6 @@
"""Various utility functions."""
-from collections import namedtuple, OrderedDict
+from collections import namedtuple, Counter
from os.path import commonprefix
__unittest = True
@@ -153,17 +153,10 @@ def _count_diff_all_purpose(actual, expected):
result.append(diff)
return result
-def _ordered_count(iterable):
- 'Return dict of element counts, in the order they were first seen'
- c = OrderedDict()
- for elem in iterable:
- c[elem] = c.get(elem, 0) + 1
- return c
-
def _count_diff_hashable(actual, expected):
'Returns list of (cnt_act, cnt_exp, elem) triples where the counts differ'
# elements must be hashable
- s, t = _ordered_count(actual), _ordered_count(expected)
+ s, t = Counter(actual), Counter(expected)
result = []
for elem, cnt_s in s.items():
cnt_t = t.get(elem, 0)
More information about the Python-checkins
mailing list