[Python-checkins] bpo-32008: don't use PROTOCOL_TLSv1 in example (GH-5789)

Miss Islington (bot) webhook-mailer at python.org
Wed Feb 21 01:02:21 EST 2018


https://github.com/python/cpython/commit/e5d38deb045d0907e6fcf82af8d2d8f0556a8591
commit: e5d38deb045d0907e6fcf82af8d2d8f0556a8591
branch: 3.7
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2018-02-20T22:02:18-08:00
summary:

bpo-32008: don't use PROTOCOL_TLSv1 in example (GH-5789)


It's bad form to pin to an old version of TLS. ssl.SSLContext has the right
protocol default, so let's not pass anyway.
(cherry picked from commit e9edee0b65650c4f9db90cefc2e9a8125bad762c)

Co-authored-by: Benjamin Peterson <benjamin at python.org>

files:
M Doc/library/ssl.rst

diff --git a/Doc/library/ssl.rst b/Doc/library/ssl.rst
index aa1075d4b02b..21da4f638713 100644
--- a/Doc/library/ssl.rst
+++ b/Doc/library/ssl.rst
@@ -1707,7 +1707,7 @@ to speed up repeated connections from the same clients.
 
       import socket, ssl
 
-      context = ssl.SSLContext(ssl.PROTOCOL_TLSv1)
+      context = ssl.SSLContext()
       context.verify_mode = ssl.CERT_REQUIRED
       context.check_hostname = True
       context.load_default_certs()
@@ -1952,7 +1952,7 @@ If you prefer to tune security settings yourself, you might create
 a context from scratch (but beware that you might not get the settings
 right)::
 
-   >>> context = ssl.SSLContext(ssl.PROTOCOL_TLS)
+   >>> context = ssl.SSLContext()
    >>> context.verify_mode = ssl.CERT_REQUIRED
    >>> context.check_hostname = True
    >>> context.load_verify_locations("/etc/ssl/certs/ca-bundle.crt")



More information about the Python-checkins mailing list