[Python-checkins] Make sure file object is close if socket.create_connection fails (GH-11334)
Pablo Galindo
webhook-mailer at python.org
Fri Dec 28 20:42:20 EST 2018
https://github.com/python/cpython/commit/1f511e1af060e98fb789319a96076c06e7f98135
commit: 1f511e1af060e98fb789319a96076c06e7f98135
branch: master
author: Pablo Galindo <Pablogsal at gmail.com>
committer: GitHub <noreply at github.com>
date: 2018-12-29T01:42:16Z
summary:
Make sure file object is close if socket.create_connection fails (GH-11334)
The problem affects _testWithTimeoutTriggeredSend in test_socket.py.
files:
M Lib/test/test_socket.py
diff --git a/Lib/test/test_socket.py b/Lib/test/test_socket.py
index 36d3d5ed12b3..7c5167d85033 100644
--- a/Lib/test/test_socket.py
+++ b/Lib/test/test_socket.py
@@ -5787,11 +5787,10 @@ def testWithTimeout(self):
def _testWithTimeoutTriggeredSend(self):
address = self.serv.getsockname()
- file = open(support.TESTFN, 'rb')
- with socket.create_connection(address, timeout=0.01) as sock, \
- file as file:
- meth = self.meth_from_sock(sock)
- self.assertRaises(socket.timeout, meth, file)
+ with open(support.TESTFN, 'rb') as file:
+ with socket.create_connection(address, timeout=0.01) as sock:
+ meth = self.meth_from_sock(sock)
+ self.assertRaises(socket.timeout, meth, file)
def testWithTimeoutTriggeredSend(self):
conn = self.accept_conn()
More information about the Python-checkins
mailing list