[Python-checkins] bpo-11566: Extension build errors on Windows for _hypot (GH-11283)
INADA Naoki
webhook-mailer at python.org
Fri Dec 21 20:38:04 EST 2018
https://github.com/python/cpython/commit/87667c54c6650751c5d7bf7b9e465c8c4af45f71
commit: 87667c54c6650751c5d7bf7b9e465c8c4af45f71
branch: master
author: Matt McCormick <matt at mmmccormick.com>
committer: INADA Naoki <methane at users.noreply.github.com>
date: 2018-12-22T10:37:59+09:00
summary:
bpo-11566: Extension build errors on Windows for _hypot (GH-11283)
This addresses C extension build errors related to an undefined _hypot
symbol when building with the Microsoft Visual C++ Compiler for Python
2.7 [1] or MinGWPy [2]. It also addresses errors when building a C++
extension with MinGWPy and C++11 from cmath, 'error "::hypot' has not
been declared'
[1] https://www.microsoft.com/en-us/download/details.aspx?id=44266
[2] https://mingwpy.github.io/
files:
M PC/pyconfig.h
diff --git a/PC/pyconfig.h b/PC/pyconfig.h
index b5e3452460c4..0f1fcdd944cb 100644
--- a/PC/pyconfig.h
+++ b/PC/pyconfig.h
@@ -192,11 +192,6 @@ typedef int pid_t;
#define Py_IS_FINITE(X) _finite(X)
#define copysign _copysign
-/* VS 2010 and above already defines hypot as _hypot */
-#if _MSC_VER < 1600
-#define hypot _hypot
-#endif
-
/* VS 2015 defines these names with a leading underscore */
#if _MSC_VER >= 1900
#define timezone _timezone
@@ -231,7 +226,6 @@ typedef int pid_t;
#endif
#define COMPILER "[gcc]"
-#define hypot _hypot
#define PY_LONG_LONG long long
#define PY_LLONG_MIN LLONG_MIN
#define PY_LLONG_MAX LLONG_MAX
More information about the Python-checkins
mailing list