[Python-checkins] closes bpo-34477: Objects/typeobject.c: Add missing NULL check to type_init() (GH-8876)

Benjamin Peterson webhook-mailer at python.org
Fri Aug 24 00:22:19 EDT 2018


https://github.com/python/cpython/commit/f6247aac08c1a79d0479145a405718bb76dba434
commit: f6247aac08c1a79d0479145a405718bb76dba434
branch: master
author: Alexey Izbyshev <izbyshev at ispras.ru>
committer: Benjamin Peterson <benjamin at python.org>
date: 2018-08-23T21:22:16-07:00
summary:

closes bpo-34477: Objects/typeobject.c: Add missing NULL check to type_init() (GH-8876)

Reported by Svace static analyzer.

files:
M Objects/typeobject.c

diff --git a/Objects/typeobject.c b/Objects/typeobject.c
index a7a9d7bf9fc3..af9685d17d5f 100644
--- a/Objects/typeobject.c
+++ b/Objects/typeobject.c
@@ -2295,6 +2295,9 @@ type_init(PyObject *cls, PyObject *args, PyObject *kwds)
     /* Call object.__init__(self) now. */
     /* XXX Could call super(type, cls).__init__() but what's the point? */
     args = PyTuple_GetSlice(args, 0, 0);
+    if (args == NULL) {
+        return -1;
+    }
     res = object_init(cls, args, NULL);
     Py_DECREF(args);
     return res;



More information about the Python-checkins mailing list