[Python-checkins] bpo-34325: Skip zipfile test for large timestamps when filesystem don't support them. (GH-8656)

Petr Viktorin webhook-mailer at python.org
Fri Aug 3 11:59:24 EDT 2018


https://github.com/python/cpython/commit/7b41dbad78c6b03ca2f98800a92a1977d3946643
commit: 7b41dbad78c6b03ca2f98800a92a1977d3946643
branch: master
author: Marcel Plch <gmarcel.plch at gmail.com>
committer: Petr Viktorin <encukou at gmail.com>
date: 2018-08-03T17:59:19+02:00
summary:

bpo-34325: Skip zipfile test for large timestamps when filesystem don't support them. (GH-8656)

When the filesystem doesn't support files with large timestamps,
skip testing that such files can be zipped.

files:
M Lib/test/test_zipfile.py

diff --git a/Lib/test/test_zipfile.py b/Lib/test/test_zipfile.py
index 3b78b7f16759..68b56a0cd988 100644
--- a/Lib/test/test_zipfile.py
+++ b/Lib/test/test_zipfile.py
@@ -556,7 +556,11 @@ def test_add_file_before_1980(self):
 
     def test_add_file_after_2107(self):
         # Set atime and mtime to 2108-12-30
-        os.utime(TESTFN, (4386268800, 4386268800))
+        try:
+            os.utime(TESTFN, (4386268800, 4386268800))
+        except OverflowError:
+            self.skipTest('Host fs cannot set timestamp to required value.')
+
         with zipfile.ZipFile(TESTFN2, "w") as zipfp:
             self.assertRaises(struct.error, zipfp.write, TESTFN)
 



More information about the Python-checkins mailing list