[Python-checkins] bpo-33295: Skip test using missing external site (GH-6504) (GH-6511)

Ned Deily webhook-mailer at python.org
Tue Apr 17 11:36:33 EDT 2018


https://github.com/python/cpython/commit/f1547d110ff195291e29ba5c29617912d12ecbec
commit: f1547d110ff195291e29ba5c29617912d12ecbec
branch: 3.6
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: Ned Deily <nad at python.org>
date: 2018-04-17T11:36:30-04:00
summary:

bpo-33295: Skip test using missing external site (GH-6504) (GH-6511)

`test_urllib2net.OtherNetworkTests.test_sites_no_connection_close`
used `http://www.imdb.com/` but it is moved to https so the test is
not valid anymore.  Skip test for the moment to allow CI to proceed.
(cherry picked from commit 36d56ea826caffbeac0fc0c6d90248b80516e33c)

Co-authored-by: INADA Naoki <methane at users.noreply.github.com>

files:
M Lib/test/test_urllib2net.py

diff --git a/Lib/test/test_urllib2net.py b/Lib/test/test_urllib2net.py
index 13e2dd5b7842..15f73de9f029 100644
--- a/Lib/test/test_urllib2net.py
+++ b/Lib/test/test_urllib2net.py
@@ -177,6 +177,7 @@ def test_custom_headers(self):
             opener.open(request)
             self.assertEqual(request.get_header('User-agent'),'Test-Agent')
 
+    @unittest.skip('XXX: http://www.imdb.com is gone')
     def test_sites_no_connection_close(self):
         # Some sites do not send Connection: close header.
         # Verify that those work properly. (#issue12576)



More information about the Python-checkins mailing list