[Python-checkins] Removed a confusing line from a docstring in http.cookies (GH-6482)

Alex Gaynor webhook-mailer at python.org
Sun Apr 15 17:23:49 EDT 2018


https://github.com/python/cpython/commit/afbbac12a517818a1efa88f7bea18e82b68a79d4
commit: afbbac12a517818a1efa88f7bea18e82b68a79d4
branch: master
author: Alex Gaynor <alex.gaynor at gmail.com>
committer: GitHub <noreply at github.com>
date: 2018-04-15T17:23:47-04:00
summary:

Removed a confusing line from a docstring in http.cookies (GH-6482)

There's no reason a cookie should _ever_ contain pickled data. That's just asking for a critical security vulnerability. Back in Python2 there were helpers for doing that, but they're no more in Python3. Now coded_value is used when the value needs to be encoded for any reason.

files:
M Lib/http/cookies.py

diff --git a/Lib/http/cookies.py b/Lib/http/cookies.py
index 4a44db8475ea..b2e995c0c47f 100644
--- a/Lib/http/cookies.py
+++ b/Lib/http/cookies.py
@@ -256,8 +256,7 @@ class Morsel(dict):
     In a cookie, each such pair may have several attributes, so this class is
     used to keep the attributes associated with the appropriate key,value pair.
     This class also includes a coded_value attribute, which is used to hold
-    the network representation of the value.  This is most useful when Python
-    objects are pickled for network transit.
+    the network representation of the value.
     """
     # RFC 2109 lists these attributes as reserved:
     #   path       comment         domain



More information about the Python-checkins mailing list