[Python-checkins] remove configure check for memmove (#3716)

Benjamin Peterson webhook-mailer at python.org
Sun Sep 24 15:08:43 EDT 2017


https://github.com/python/cpython/commit/b1d1c422ccb9a1711c2d90660373edce9204adcb
commit: b1d1c422ccb9a1711c2d90660373edce9204adcb
branch: master
author: Benjamin Peterson <benjamin at python.org>
committer: GitHub <noreply at github.com>
date: 2017-09-24T12:08:40-07:00
summary:

remove configure check for memmove (#3716)

Python requires C implementations provide memmove, so we shouldn't need to check for it. The only place using this configure check was expat, where we can simply always define HAVE_MEMMOVE.

files:
M Modules/expat/expat_config.h
M configure
M configure.ac
M pyconfig.h.in

diff --git a/Modules/expat/expat_config.h b/Modules/expat/expat_config.h
index b8c1639b976..afbedd011f6 100644
--- a/Modules/expat/expat_config.h
+++ b/Modules/expat/expat_config.h
@@ -12,6 +12,8 @@
 #define BYTEORDER 1234
 #endif
 
+#define HAVE_MEMMOVE 1
+
 #define XML_NS 1
 #define XML_DTD 1
 #define XML_CONTEXT_BYTES 1024
diff --git a/configure b/configure
index 00dd1f0514a..819dc7a0c16 100755
--- a/configure
+++ b/configure
@@ -12253,19 +12253,6 @@ fi
 done
 
 
-# Stuff for expat.
-for ac_func in memmove
-do :
-  ac_fn_c_check_func "$LINENO" "memmove" "ac_cv_func_memmove"
-if test "x$ac_cv_func_memmove" = xyes; then :
-  cat >>confdefs.h <<_ACEOF
-#define HAVE_MEMMOVE 1
-_ACEOF
-
-fi
-done
-
-
 # check for long file support functions
 for ac_func in fseek64 fseeko fstatvfs ftell64 ftello statvfs
 do :
diff --git a/configure.ac b/configure.ac
index 88ab6a12157..e90d05d1c8d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3684,9 +3684,6 @@ AC_CHECK_FUNCS(forkpty,,
    )
 )
 
-# Stuff for expat.
-AC_CHECK_FUNCS(memmove)
-
 # check for long file support functions
 AC_CHECK_FUNCS(fseek64 fseeko fstatvfs ftell64 ftello statvfs)
 
diff --git a/pyconfig.h.in b/pyconfig.h.in
index 4fc5a3f5a38..d4feabeece3 100644
--- a/pyconfig.h.in
+++ b/pyconfig.h.in
@@ -601,9 +601,6 @@
 /* Define to 1 if you have the `mbrtowc' function. */
 #undef HAVE_MBRTOWC
 
-/* Define to 1 if you have the `memmove' function. */
-#undef HAVE_MEMMOVE
-
 /* Define to 1 if you have the <memory.h> header file. */
 #undef HAVE_MEMORY_H
 



More information about the Python-checkins mailing list