[Python-checkins] bpo-31502: IDLE Configdialog again deletes custom themes and keysets. (#3634)

Terry Jan Reedy webhook-mailer at python.org
Sun Sep 17 20:13:28 EDT 2017


https://github.com/python/cpython/commit/0efc7c67a2f8a184e93f9a491305c81ef2e24250
commit: 0efc7c67a2f8a184e93f9a491305c81ef2e24250
branch: master
author: Terry Jan Reedy <tjreedy at udel.edu>
committer: GitHub <noreply at github.com>
date: 2017-09-17T20:13:25-04:00
summary:

bpo-31502: IDLE Configdialog again deletes custom themes and keysets. (#3634)

This reverses a never-released regression resulting from bpo-31287.

files:
M Lib/idlelib/configdialog.py

diff --git a/Lib/idlelib/configdialog.py b/Lib/idlelib/configdialog.py
index 7feae5d6199..0f530c66a11 100644
--- a/Lib/idlelib/configdialog.py
+++ b/Lib/idlelib/configdialog.py
@@ -1237,7 +1237,7 @@ def save_new(self, theme_name, theme):
 
     def askyesno(self, *args, **kwargs):
         # Make testing easier.  Could change implementation.
-        messagebox.askyesno(*args, **kwargs)
+        return messagebox.askyesno(*args, **kwargs)
 
     def delete_custom(self):
         """Handle event to delete custom theme.
@@ -1683,7 +1683,7 @@ def save_new_key_set(keyset_name, keyset):
 
     def askyesno(self, *args, **kwargs):
         # Make testing easier.  Could change implementation.
-        messagebox.askyesno(*args, **kwargs)
+        return messagebox.askyesno(*args, **kwargs)
 
     def delete_custom_keys(self):
         """Handle event to delete a custom key set.



More information about the Python-checkins mailing list