[Python-checkins] Avoid UB in test selection macro. (#3407)
Gregory P. Smith
webhook-mailer at python.org
Wed Sep 6 21:00:51 EDT 2017
https://github.com/python/cpython/commit/78ebc73f9b17373d25eb35e9f9511b2cb63825ff
commit: 78ebc73f9b17373d25eb35e9f9511b2cb63825ff
branch: master
author: Devin Jeanpierre <jeanpierreda at gmail.com>
committer: Gregory P. Smith <greg at krypto.org>
date: 2017-09-06T18:00:47-07:00
summary:
Avoid UB in test selection macro. (#3407)
This fixes the gcc "warning: this use of "defined" may not be portable [-Wexpansion-to-defined]"
See discussion in http://bugs.python.org/issue29505
files:
M Modules/_xxtestfuzz/fuzzer.c
diff --git a/Modules/_xxtestfuzz/fuzzer.c b/Modules/_xxtestfuzz/fuzzer.c
index 36f721ee626..b50eb651271 100644
--- a/Modules/_xxtestfuzz/fuzzer.c
+++ b/Modules/_xxtestfuzz/fuzzer.c
@@ -105,16 +105,14 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) {
int rv = 0;
-#define _Py_FUZZ_YES(test_name) (defined(_Py_FUZZ_##test_name) || !defined(_Py_FUZZ_ONE))
-#if _Py_FUZZ_YES(fuzz_builtin_float)
+#if !defined(_Py_FUZZ_ONE) || defined(_Py_FUZZ_fuzz_builtin_float)
rv |= _run_fuzz(data, size, fuzz_builtin_float);
#endif
-#if _Py_FUZZ_YES(fuzz_builtin_int)
+#if !defined(_Py_FUZZ_ONE) || defined(_Py_FUZZ_fuzz_builtin_int)
rv |= _run_fuzz(data, size, fuzz_builtin_int);
#endif
-#if _Py_FUZZ_YES(fuzz_builtin_unicode)
+#if !defined(_Py_FUZZ_ONE) || defined(_Py_FUZZ_fuzz_builtin_unicode)
rv |= _run_fuzz(data, size, fuzz_builtin_unicode);
#endif
-#undef _Py_FUZZ_YES
return rv;
}
More information about the Python-checkins
mailing list