[Python-checkins] remove a redundant lower in urllib.parse.urlsplit (#3008)

Senthil Kumaran webhook-mailer at python.org
Sun Sep 3 00:51:44 EDT 2017


https://github.com/python/cpython/commit/8df44ee8e0fbdb390bd38eb88eb1ee4e2a10d355
commit: 8df44ee8e0fbdb390bd38eb88eb1ee4e2a10d355
branch: master
author: Oren Milman <orenmn at gmail.com>
committer: Senthil Kumaran <skumaran at gatech.edu>
date: 2017-09-02T21:51:39-07:00
summary:

remove a redundant lower in urllib.parse.urlsplit (#3008)

files:
M Lib/urllib/parse.py

diff --git a/Lib/urllib/parse.py b/Lib/urllib/parse.py
index 01eb54906c8..76086e58bea 100644
--- a/Lib/urllib/parse.py
+++ b/Lib/urllib/parse.py
@@ -407,7 +407,6 @@ def urlsplit(url, scheme='', allow_fragments=True):
     i = url.find(':')
     if i > 0:
         if url[:i] == 'http': # optimize the common case
-            scheme = url[:i].lower()
             url = url[i+1:]
             if url[:2] == '//':
                 netloc, url = _splitnetloc(url, 2)
@@ -418,7 +417,7 @@ def urlsplit(url, scheme='', allow_fragments=True):
                 url, fragment = url.split('#', 1)
             if '?' in url:
                 url, query = url.split('?', 1)
-            v = SplitResult(scheme, netloc, url, query, fragment)
+            v = SplitResult('http', netloc, url, query, fragment)
             _parse_cache[key] = v
             return _coerce_result(v)
         for c in url[:i]:



More information about the Python-checkins mailing list