[Python-checkins] Fix a test for select.kevent. (#4349)

Serhiy Storchaka webhook-mailer at python.org
Thu Nov 9 12:04:50 EST 2017


https://github.com/python/cpython/commit/15e14538f90cabc87473a489316fdb81af76cfb2
commit: 15e14538f90cabc87473a489316fdb81af76cfb2
branch: 2.7
author: Serhiy Storchaka <storchaka at gmail.com>
committer: GitHub <noreply at github.com>
date: 2017-11-09T19:04:47+02:00
summary:

Fix a test for select.kevent. (#4349)

select.kevent objects are now comparable with other objects in Python 2.

files:
M Lib/test/test_kqueue.py

diff --git a/Lib/test/test_kqueue.py b/Lib/test/test_kqueue.py
index c599e021756..b3722033f39 100644
--- a/Lib/test/test_kqueue.py
+++ b/Lib/test/test_kqueue.py
@@ -36,9 +36,12 @@ def test_create_event(self):
         self.assertEqual(cmp(ev, other), -1)
         self.assertTrue(ev < other)
         self.assertTrue(other >= ev)
-        self.assertRaises(TypeError, cmp, ev, None)
-        self.assertRaises(TypeError, cmp, ev, 1)
-        self.assertRaises(TypeError, cmp, ev, "ev")
+        self.assertNotEqual(cmp(ev, None), 0)
+        self.assertNotEqual(cmp(ev, 1), 0)
+        self.assertNotEqual(cmp(ev, "ev"), 0)
+        self.assertEqual(cmp(ev, None), -cmp(None, ev))
+        self.assertEqual(cmp(ev, 1), -cmp(1, ev))
+        self.assertEqual(cmp(ev, "ev"), -cmp("ev", ev))
 
         ev = select.kevent(fd, select.KQ_FILTER_WRITE)
         self.assertEqual(ev.ident, fd)



More information about the Python-checkins mailing list