[Python-checkins] bpo-31067: test_subprocess calls reap_children() (#2931)

Victor Stinner webhook-mailer at python.org
Fri Jul 28 12:00:25 EDT 2017


https://github.com/python/cpython/commit/cc42c121eb5346f673247f95dac575aadb77d66c
commit: cc42c121eb5346f673247f95dac575aadb77d66c
branch: master
author: Victor Stinner <victor.stinner at gmail.com>
committer: GitHub <noreply at github.com>
date: 2017-07-28T18:00:22+02:00
summary:

bpo-31067: test_subprocess calls reap_children() (#2931)

test_subprocess now also calls reap_children() in tearDown(), not
only on setUp().

files:
M Lib/test/test_subprocess.py

diff --git a/Lib/test/test_subprocess.py b/Lib/test/test_subprocess.py
index 4052c5ef525..a99976aa56f 100644
--- a/Lib/test/test_subprocess.py
+++ b/Lib/test/test_subprocess.py
@@ -56,6 +56,8 @@ def tearDown(self):
             inst.wait()
         subprocess._cleanup()
         self.assertFalse(subprocess._active, "subprocess._active not empty")
+        self.doCleanups()
+        support.reap_children()
 
     def assertStderrEqual(self, stderr, expected, msg=None):
         # In a debug build, stuff like "[6580 refs]" is printed to stderr at



More information about the Python-checkins mailing list