[Python-checkins] bpo-31044: Skip test_posix.test_makedev() on FreeBSD (#2915) (#2917)

Victor Stinner webhook-mailer at python.org
Thu Jul 27 12:42:14 EDT 2017


https://github.com/python/cpython/commit/54cb3400e500f99bd57a0273aa7ef84ffd37558e
commit: 54cb3400e500f99bd57a0273aa7ef84ffd37558e
branch: 3.6
author: Victor Stinner <victor.stinner at gmail.com>
committer: GitHub <noreply at github.com>
date: 2017-07-27T18:42:11+02:00
summary:

bpo-31044: Skip test_posix.test_makedev() on FreeBSD (#2915) (#2917)

There is a bug in FreeBSD CURRENT with 64-bit dev_t. Skip the test if
dev_t is larger than 32-bit, until the bug is fixed in FreeBSD
CURRENT.
(cherry picked from commit 12953ffe12ac781332b384c36b25d12216b1db62)

files:
M Lib/test/test_posix.py

diff --git a/Lib/test/test_posix.py b/Lib/test/test_posix.py
index a6e2fed302f..9df3206324f 100644
--- a/Lib/test/test_posix.py
+++ b/Lib/test/test_posix.py
@@ -478,6 +478,10 @@ def test_makedev(self):
         self.assertRaises(TypeError, posix.minor)
         self.assertRaises((ValueError, OverflowError), posix.minor, -1)
 
+        if sys.platform.startswith('freebsd') and dev >= 0x1_0000_0000:
+            self.skipTest("bpo-31044: on FreeBSD CURRENT, minor() truncates "
+                          "64-bit dev to 32-bit")
+
         self.assertEqual(posix.makedev(major, minor), dev)
         self.assertRaises(TypeError, posix.makedev, float(major), minor)
         self.assertRaises(TypeError, posix.makedev, major, float(minor))



More information about the Python-checkins mailing list