[Python-checkins] cpython: sorted() uses METH_FASTCALL

victor.stinner python-checkins at python.org
Tue Jan 17 09:25:13 EST 2017


https://hg.python.org/cpython/rev/b34d2ef5c412
changeset:   106202:b34d2ef5c412
user:        Victor Stinner <victor.stinner at gmail.com>
date:        Tue Jan 17 15:17:49 2017 +0100
summary:
  sorted() uses METH_FASTCALL

files:
  Python/bltinmodule.c |  22 ++++++++++------------
  1 files changed, 10 insertions(+), 12 deletions(-)


diff --git a/Python/bltinmodule.c b/Python/bltinmodule.c
--- a/Python/bltinmodule.c
+++ b/Python/bltinmodule.c
@@ -2121,20 +2121,20 @@
 "reverse flag can be set to request the result in descending order.");
 
 #define BUILTIN_SORTED_METHODDEF    \
-    {"sorted", (PyCFunction)builtin_sorted, METH_VARARGS|METH_KEYWORDS, builtin_sorted__doc__},
+    {"sorted", (PyCFunction)builtin_sorted, METH_FASTCALL, builtin_sorted__doc__},
 
 static PyObject *
-builtin_sorted(PyObject *self, PyObject *args, PyObject *kwds)
+builtin_sorted(PyObject *self, PyObject **args, Py_ssize_t nargs, PyObject *kwnames)
 {
-    PyObject *newlist, *v, *seq, *keyfunc=NULL, **newargs;
+    PyObject *newlist, *v, *seq, *keyfunc=NULL;
     PyObject *callable;
-    static char *kwlist[] = {"iterable", "key", "reverse", 0};
+    static const char * const kwlist[] = {"iterable", "key", "reverse", 0};
+    /* args 1-3 should match listsort in Objects/listobject.c */
+    static _PyArg_Parser parser = {"O|Oi:sorted", kwlist, 0};
     int reverse;
-    Py_ssize_t nargs;
-
-    /* args 1-3 should match listsort in Objects/listobject.c */
-    if (!PyArg_ParseTupleAndKeywords(args, kwds, "O|Oi:sorted",
-        kwlist, &seq, &keyfunc, &reverse))
+
+    if (!_PyArg_ParseStackAndKeywords(args, nargs, kwnames, &parser,
+                                      &seq, &keyfunc, &reverse))
         return NULL;
 
     newlist = PySequence_List(seq);
@@ -2147,9 +2147,7 @@
         return NULL;
     }
 
-    newargs = &PyTuple_GET_ITEM(args, 1);
-    nargs = PyTuple_GET_SIZE(args) - 1;
-    v = _PyObject_FastCallDict(callable, newargs, nargs, kwds);
+    v = _PyObject_FastCallKeywords(callable, args + 1, nargs - 1, kwnames);
     Py_DECREF(callable);
     if (v == NULL) {
         Py_DECREF(newlist);

-- 
Repository URL: https://hg.python.org/cpython


More information about the Python-checkins mailing list