[Python-checkins] bpo-31160: Fix test_builtin for zombie process (#3043)

Victor Stinner webhook-mailer at python.org
Wed Aug 9 11:44:22 EDT 2017


https://github.com/python/cpython/commit/4baca1b0f7325032598cd38e7ceffc79b616d255
commit: 4baca1b0f7325032598cd38e7ceffc79b616d255
branch: master
author: Victor Stinner <victor.stinner at gmail.com>
committer: GitHub <noreply at github.com>
date: 2017-08-09T17:44:19+02:00
summary:

bpo-31160: Fix test_builtin for zombie process (#3043)

PtyTests.run_child() now calls os.waitpid() to read the exit status
of the child process to avoid creating zombie process and leaking
processes in the background.

files:
M Lib/test/test_builtin.py

diff --git a/Lib/test/test_builtin.py b/Lib/test/test_builtin.py
index a83d20f4343..219a08abd3f 100644
--- a/Lib/test/test_builtin.py
+++ b/Lib/test/test_builtin.py
@@ -1568,6 +1568,10 @@ def run_child(self, child, terminal_input):
             self.fail("got %d lines in pipe but expected 2, child output was:\n%s"
                       % (len(lines), child_output))
         os.close(fd)
+
+        pid, status = os.waitpid(pid, 0)
+        self.assertEqual(status, 0)
+
         return lines
 
     def check_input_tty(self, prompt, terminal_input, stdio_encoding=None):



More information about the Python-checkins mailing list