[Python-checkins] [python/cpython] 98c7a9: [3.5] bpo-30107: don't dump core on expected test_...

[GitHub]

  Branch: refs/heads/3.5
  Home:   https://github.com/python/cpython
  Commit: 98c7a9e662b49029ff051b6699ddc0f542663c96
      https://github.com/python/cpython/commit/98c7a9e662b49029ff051b6699ddc0f542663c96
  Author: Victor Stinner <victor.stinner at gmail.com>
  Date:   2017-04-28 (Fri, 28 Apr 2017)

  Changed paths:
    M Lib/test/support/__init__.py
    M Lib/test/test_io.py

  Log Message:
  -----------
  [3.5] bpo-30107: don't dump core on expected test_io crash (#1235) (#1344)

* bpo-30107: Make SuppressCrashReport quiet on macOS (#1279) (#1335)

On macOS, SuppressCrashReport now redirects /usr/bin/defaults command
stderr into a pipe to not pollute stderr. It fixes a
test_io.test_daemon_threads_shutdown_stderr_deadlock() failure when
the CrashReporter domain doesn't exists. Message logged into stderr:

2017-04-24 16:57:21.432 defaults[41046:2462851]
The domain/default pair of (com.apple.CrashReporter, DialogType) does not exist
(cherry picked from commit d819ad9832292d854e9710493ecdf959b69802e3)

* bpo-30107: don't dump core on expected test_io crash (#1235)

test_io has two unit tests which trigger a deadlock:

* test_daemon_threads_shutdown_stdout_deadlock()
* test_daemon_threads_shutdown_stderr_deadlock()

These tests call Py_FatalError() if the expected bug is triggered
which calls abort(). Use test.support.SuppressCrashReport to prevent
the creation on a core dump, to fix the warning:

Warning -- files was modified by test_io
  Before: []
  After:  ['python.core']