[Python-checkins] [python/cpython] 7b9619: Fix/optimize test_asyncore.test_quick_connect() (#...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/python/cpython
  Commit: 7b9619ae249ed637924d1c76687b411061753e5a
      https://github.com/python/cpython/commit/7b9619ae249ed637924d1c76687b411061753e5a
  Author: Victor Stinner <victor.stinner at gmail.com>
  Date:   2017-04-19 (Wed, 19 Apr 2017)

  Changed paths:
    M Lib/test/test_asyncore.py

  Log Message:
  -----------
  Fix/optimize test_asyncore.test_quick_connect() (#1188)

Don't use addCleanup() in test_quick_connect() because it keeps the
Thread object alive and so @reap_threads fails on its timeout of 1
second. "./python -m test -v test_asyncore -m test_quick_connect"
now takes 185 ms, instead of 11 seconds.

Other minor changes:

* Use "with sock:" to close the socket instead of
  try/finally: sock.close()
* Use self.skipTest() in test_quick_connect() to remove one
  indentation level and notice user that the test is specific to
  AF_INET and AF_INET6