[Python-checkins] cpython (2.7): remove fix_callable, callable() was readded long ago in 3.x.

gregory.p.smith python-checkins at python.org
Fri Sep 9 21:33:51 EDT 2016


https://hg.python.org/cpython/rev/af4529e3594d
changeset:   103526:af4529e3594d
branch:      2.7
user:        Gregory P. Smith <greg at krypto.org> [Google Inc.]
date:        Fri Sep 09 18:33:32 2016 -0700
summary:
  remove fix_callable, callable() was readded long ago in 3.x.

files:
  Lib/lib2to3/fixes/fix_callable.py |  37 -------------------
  1 files changed, 0 insertions(+), 37 deletions(-)


diff --git a/Lib/lib2to3/fixes/fix_callable.py b/Lib/lib2to3/fixes/fix_callable.py
deleted file mode 100644
--- a/Lib/lib2to3/fixes/fix_callable.py
+++ /dev/null
@@ -1,37 +0,0 @@
-# Copyright 2007 Google, Inc. All Rights Reserved.
-# Licensed to PSF under a Contributor Agreement.
-
-"""Fixer for callable().
-
-This converts callable(obj) into isinstance(obj, collections.Callable), adding a
-collections import if needed."""
-
-# Local imports
-from lib2to3 import fixer_base
-from lib2to3.fixer_util import Call, Name, String, Attr, touch_import
-
-class FixCallable(fixer_base.BaseFix):
-    BM_compatible = True
-
-    order = "pre"
-
-    # Ignore callable(*args) or use of keywords.
-    # Either could be a hint that the builtin callable() is not being used.
-    PATTERN = """
-    power< 'callable'
-           trailer< lpar='('
-                    ( not(arglist | argument<any '=' any>) func=any
-                      | func=arglist<(not argument<any '=' any>) any ','> )
-                    rpar=')' >
-           after=any*
-    >
-    """
-
-    def transform(self, node, results):
-        func = results['func']
-
-        touch_import(None, u'collections', node=node)
-
-        args = [func.clone(), String(u', ')]
-        args.extend(Attr(Name(u'collections'), Name(u'Callable')))
-        return Call(Name(u'isinstance'), args, prefix=node.prefix)

-- 
Repository URL: https://hg.python.org/cpython


More information about the Python-checkins mailing list