[Python-checkins] cpython (3.5): Issue #16181: cookiejar.http2time() now returns None if year is higher than
berker.peksag
python-checkins at python.org
Sun Mar 13 23:47:43 EDT 2016
https://hg.python.org/cpython/rev/838f68a76ea1
changeset: 100518:838f68a76ea1
branch: 3.5
parent: 100515:78e9c18d3e5b
user: Berker Peksag <berker.peksag at gmail.com>
date: Mon Mar 14 05:48:02 2016 +0200
summary:
Issue #16181: cookiejar.http2time() now returns None if year is higher than datetime.MAXYEAR
files:
Lib/http/cookiejar.py | 5 ++++-
Lib/test/test_http_cookiejar.py | 4 ++++
Misc/NEWS | 3 +++
3 files changed, 11 insertions(+), 1 deletions(-)
diff --git a/Lib/http/cookiejar.py b/Lib/http/cookiejar.py
--- a/Lib/http/cookiejar.py
+++ b/Lib/http/cookiejar.py
@@ -143,6 +143,10 @@
return offset
def _str2time(day, mon, yr, hr, min, sec, tz):
+ yr = int(yr)
+ if yr > datetime.MAXYEAR:
+ return None
+
# translate month name to number
# month numbers start with 1 (January)
try:
@@ -163,7 +167,6 @@
if min is None: min = 0
if sec is None: sec = 0
- yr = int(yr)
day = int(day)
hr = int(hr)
min = int(min)
diff --git a/Lib/test/test_http_cookiejar.py b/Lib/test/test_http_cookiejar.py
--- a/Lib/test/test_http_cookiejar.py
+++ b/Lib/test/test_http_cookiejar.py
@@ -91,6 +91,10 @@
'01-01-1980 25:00:00',
'01-01-1980 00:61:00',
'01-01-1980 00:00:62',
+ '08-Oct-3697739',
+ '08-01-3697739',
+ '09 Feb 19942632 22:23:32 GMT',
+ 'Wed, 09 Feb 1994834 22:23:32 GMT',
]:
self.assertIsNone(http2time(test),
"http2time(%s) is not None\n"
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -91,6 +91,9 @@
Library
-------
+- Issue #16181: cookiejar.http2time() now returns None if year is higher than
+ datetime.MAXYEAR.
+
- Issue #26513: Fixes platform module detection of Windows Server
- Issue #23718: Fixed parsing time in week 0 before Jan 1. Original patch by
--
Repository URL: https://hg.python.org/cpython
More information about the Python-checkins
mailing list