[Python-checkins] cpython (3.5): - Issue #24705: Fix sysconfig._parse_makefile not expanding ${} vars

matthias.klose python-checkins at python.org
Mon Jan 11 15:43:35 EST 2016


https://hg.python.org/cpython/rev/ef84d21f5292
changeset:   99854:ef84d21f5292
branch:      3.5
parent:      99848:e79eddcdff63
user:        doko at ubuntu.com
date:        Mon Jan 11 21:41:40 2016 +0100
summary:
  - Issue #24705: Fix sysconfig._parse_makefile not expanding ${} vars
  appearing before $() vars.

files:
  Lib/sysconfig.py |  7 ++++++-
  Misc/NEWS        |  3 +++
  2 files changed, 9 insertions(+), 1 deletions(-)


diff --git a/Lib/sysconfig.py b/Lib/sysconfig.py
--- a/Lib/sysconfig.py
+++ b/Lib/sysconfig.py
@@ -260,7 +260,12 @@
     while len(variables) > 0:
         for name in tuple(variables):
             value = notdone[name]
-            m = _findvar1_rx.search(value) or _findvar2_rx.search(value)
+            m1 = _findvar1_rx.search(value)
+            m2 = _findvar2_rx.search(value)
+            if m1 and m2:
+                m = m1 if m1.start() < m2.start() else m2
+            else:
+                m = m1 if m1 else m2
             if m is not None:
                 n = m.group(1)
                 found = True
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -44,6 +44,9 @@
 Library
 -------
 
+- Issue #24705: Fix sysconfig._parse_makefile not expanding ${} vars
+  appearing before $() vars.
+
 - Issue #22138: Fix mock.patch behavior when patching descriptors. Restore
   original values after patching. Patch contributed by Sean McCully.
 

-- 
Repository URL: https://hg.python.org/cpython


More information about the Python-checkins mailing list