[Python-checkins] cpython (3.6): Issue #28843: Fix asyncio C Task to handle exceptions __traceback__.
yury.selivanov
python-checkins at python.org
Thu Dec 1 11:38:02 EST 2016
https://hg.python.org/cpython/rev/c9f68150cf90
changeset: 105405:c9f68150cf90
branch: 3.6
parent: 105393:2dd08b5b5ee6
user: Yury Selivanov <yury at magic.io>
date: Thu Dec 01 11:36:22 2016 -0500
summary:
Issue #28843: Fix asyncio C Task to handle exceptions __traceback__.
files:
Lib/test/test_asyncio/test_tasks.py | 15 +++++++++++++++
Misc/NEWS | 2 ++
Modules/_asynciomodule.c | 5 +++++
3 files changed, 22 insertions(+), 0 deletions(-)
diff --git a/Lib/test/test_asyncio/test_tasks.py b/Lib/test/test_asyncio/test_tasks.py
--- a/Lib/test/test_asyncio/test_tasks.py
+++ b/Lib/test/test_asyncio/test_tasks.py
@@ -1952,6 +1952,21 @@
self.assertFalse(gather_task.cancelled())
self.assertEqual(gather_task.result(), [42])
+ def test_exception_traceback(self):
+ # See http://bugs.python.org/issue28843
+
+ @asyncio.coroutine
+ def foo():
+ 1 / 0
+
+ @asyncio.coroutine
+ def main():
+ task = self.new_task(self.loop, foo())
+ yield # skip one loop iteration
+ self.assertIsNotNone(task.exception().__traceback__)
+
+ self.loop.run_until_complete(main())
+
@mock.patch('asyncio.base_events.logger')
def test_error_in_call_soon(self, m_log):
def call_soon(callback, *args):
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -24,6 +24,8 @@
- Issue #24142: Reading a corrupt config file left configparser in an
invalid state. Original patch by Florian Höch.
+- Issue #28843: Fix asyncio C Task to handle exceptions __traceback__.
+
Tools/Demos
-----------
diff --git a/Modules/_asynciomodule.c b/Modules/_asynciomodule.c
--- a/Modules/_asynciomodule.c
+++ b/Modules/_asynciomodule.c
@@ -1042,6 +1042,8 @@
if (PyExceptionClass_Check(type)) {
PyErr_NormalizeException(&type, &val, &tb);
+ /* No need to call PyException_SetTraceback since we'll be calling
+ PyErr_Restore for `type`, `val`, and `tb`. */
} else if (PyExceptionInstance_Check(type)) {
if (val) {
PyErr_SetString(PyExc_TypeError,
@@ -2003,6 +2005,9 @@
if (!ev || !PyObject_TypeCheck(ev, (PyTypeObject *) et)) {
PyErr_NormalizeException(&et, &ev, &tb);
}
+ if (tb != NULL) {
+ PyException_SetTraceback(ev, tb);
+ }
o = future_set_exception((FutureObj*)task, ev);
if (!o) {
/* An exception in Task.set_exception() */
--
Repository URL: https://hg.python.org/cpython
More information about the Python-checkins
mailing list