[Python-checkins] cpython (3.5): Issue #27922: IDLE tests no longer flash tk widgets.

terry.reedy python-checkins at python.org
Wed Aug 31 21:09:18 EDT 2016


https://hg.python.org/cpython/rev/ff3a6303c5b1
changeset:   102982:ff3a6303c5b1
branch:      3.5
parent:      102977:5ae941fef3be
user:        Terry Jan Reedy <tjreedy at udel.edu>
date:        Wed Aug 31 21:03:16 2016 -0400
summary:
  Issue #27922: IDLE tests no longer flash tk widgets.

files:
  Lib/idlelib/idle_test/test_configdialog.py |   1 +
  Lib/idlelib/idle_test/test_editmenu.py     |   1 +
  Lib/idlelib/idle_test/test_hyperparser.py  |   1 +
  Lib/idlelib/idle_test/test_idlehistory.py  |   1 +
  Lib/idlelib/idle_test/test_textview.py     |  12 +++++----
  Lib/idlelib/idle_test/test_widgetredir.py  |   2 +
  6 files changed, 13 insertions(+), 5 deletions(-)


diff --git a/Lib/idlelib/idle_test/test_configdialog.py b/Lib/idlelib/idle_test/test_configdialog.py
--- a/Lib/idlelib/idle_test/test_configdialog.py
+++ b/Lib/idlelib/idle_test/test_configdialog.py
@@ -15,6 +15,7 @@
     @classmethod
     def setUpClass(cls):
         cls.root = Tk()
+        cls.root.withdraw()
         macosx._initializeTkVariantTests(cls.root)
 
     @classmethod
diff --git a/Lib/idlelib/idle_test/test_editmenu.py b/Lib/idlelib/idle_test/test_editmenu.py
--- a/Lib/idlelib/idle_test/test_editmenu.py
+++ b/Lib/idlelib/idle_test/test_editmenu.py
@@ -16,6 +16,7 @@
     @classmethod
     def setUpClass(cls):
         cls.root = root = tk.Tk()
+        root.withdraw()
         PyShell.fix_x11_paste(root)
         cls.text = tk.Text(root)
         cls.entry = tk.Entry(root)
diff --git a/Lib/idlelib/idle_test/test_hyperparser.py b/Lib/idlelib/idle_test/test_hyperparser.py
--- a/Lib/idlelib/idle_test/test_hyperparser.py
+++ b/Lib/idlelib/idle_test/test_hyperparser.py
@@ -37,6 +37,7 @@
     def setUpClass(cls):
         requires('gui')
         cls.root = Tk()
+        cls.root.withdraw()
         cls.text = Text(cls.root)
         cls.editwin = DummyEditwin(cls.text)
 
diff --git a/Lib/idlelib/idle_test/test_idlehistory.py b/Lib/idlelib/idle_test/test_idlehistory.py
--- a/Lib/idlelib/idle_test/test_idlehistory.py
+++ b/Lib/idlelib/idle_test/test_idlehistory.py
@@ -68,6 +68,7 @@
     def setUpClass(cls):
         requires('gui')
         cls.root = tk.Tk()
+        cls.root.withdraw()
 
     def setUp(self):
         self.text = text = TextWrapper(self.root)
diff --git a/Lib/idlelib/idle_test/test_textview.py b/Lib/idlelib/idle_test/test_textview.py
--- a/Lib/idlelib/idle_test/test_textview.py
+++ b/Lib/idlelib/idle_test/test_textview.py
@@ -20,15 +20,16 @@
 def setUpModule():
     global root
     root = Tk()
+    root.withdraw()
 
 def tearDownModule():
     global root
     root.update_idletasks()
-    root.destroy()  # pyflakes falsely sees root as undefined
+    root.destroy()  # Pyflakes falsely sees root as undefined.
     del root
 
 
-class TV(tv.TextViewer):  # used by TextViewTest
+class TV(tv.TextViewer):  # Used in TextViewTest.
     transient = Func()
     grab_set = Func()
     wait_window = Func()
@@ -59,8 +60,8 @@
         view.destroy = Func()
         view.Ok()
         self.assertTrue(view.destroy.called)
-        del view.destroy  # unmask real function
-        view.destroy
+        del view.destroy  # Unmask real function.
+        view.destroy()
 
 
 class textviewTest(unittest.TestCase):
@@ -76,9 +77,10 @@
         del cls.orig_mbox
 
     def test_view_text(self):
-        # If modal True, tkinter will error with 'can't invoke "event" command'
+        # If modal True, get tk error 'can't invoke "event" command'.
         view = tv.view_text(root, 'Title', 'test text', modal=False)
         self.assertIsInstance(view, tv.TextViewer)
+        view.Ok()
 
     def test_view_file(self):
         test_dir = os.path.dirname(__file__)
diff --git a/Lib/idlelib/idle_test/test_widgetredir.py b/Lib/idlelib/idle_test/test_widgetredir.py
--- a/Lib/idlelib/idle_test/test_widgetredir.py
+++ b/Lib/idlelib/idle_test/test_widgetredir.py
@@ -15,6 +15,7 @@
     def setUpClass(cls):
         requires('gui')
         cls.root = Tk()
+        cls.root.withdraw()
         cls.text = Text(cls.root)
 
     @classmethod
@@ -44,6 +45,7 @@
     def setUpClass(cls):
         requires('gui')
         cls.root = Tk()
+        cls.root.withdraw()
         cls.text = Text(cls.root)
 
     @classmethod

-- 
Repository URL: https://hg.python.org/cpython


More information about the Python-checkins mailing list