[Python-checkins] cpython (3.5): Issue #25164: Changes default all-users install directory to match per-user

[steve.dower]

https://hg.python.org/cpython/rev/be92f6ce1e80
changeset:   98758:be92f6ce1e80
branch:      3.5
parent:      98755:88e6641c3dd3
user:        Steve Dower <steve.dower at microsoft.com>
date:        Wed Oct 14 10:36:36 2015 -0700
summary:
  Issue #25164: Changes default all-users install directory to match per-user directory.

files:
  Misc/NEWS                                         |   3 +
  Tools/msi/bundle/bundle.wxs                       |  12 ++--
  Tools/msi/bundle/packagegroups/packageinstall.wxs |   4 +-
  Tools/msi/bundle/packagegroups/postinstall.wxs    |  24 +++++-----
  4 files changed, 24 insertions(+), 19 deletions(-)


diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -320,6 +320,9 @@
 Windows
 -------
 
+- Issue #25164: Changes default all-users install directory to match per-user
+  directory.
+
 - Issue #25143: Improves installer error messages for unsupported platforms.
 
 - Issue #25163: Display correct directory in installer when using non-default
diff --git a/Tools/msi/bundle/bundle.wxs b/Tools/msi/bundle/bundle.wxs
--- a/Tools/msi/bundle/bundle.wxs
+++ b/Tools/msi/bundle/bundle.wxs
@@ -22,20 +22,22 @@
 
     <Variable Name="ShortVersion" Value="$(var.MajorVersionNumber).$(var.MinorVersionNumber)" />
     <Variable Name="ShortVersionNoDot" Value="$(var.MajorVersionNumber)$(var.MinorVersionNumber)" />
+    <Variable Name="WinVer" Value="$(var.MajorVersionNumber).$(var.MinorVersionNumber)$(var.Suffix32)" />
+    <Variable Name="WinVerNoDot" Value="$(var.MajorVersionNumber)$(var.MinorVersionNumber)$(var.Suffix32)" />
 
     <Variable Name="InstallAllUsers" Value="0" bal:Overridable="yes" />
     <Variable Name="InstallLauncherAllUsers" Value="1" bal:Overridable="yes" />
     <Variable Name="TargetDir" Value="" bal:Overridable="yes" />
     <?if $(var.Platform)~="x64" ?>
-    <Variable Name="DefaultAllUsersTargetDir" Value="[ProgramFiles64Folder]$(var.TestPrefix)Python [ShortVersion]" bal:Overridable="yes" />
+    <Variable Name="DefaultAllUsersTargetDir" Value="[ProgramFiles64Folder]$(var.TestPrefix)Python[WinVerNoDot]" bal:Overridable="yes" />
     <Variable Name="TargetPlatform" Value="x64" />
     <?else ?>
-    <Variable Name="DefaultAllUsersTargetDir" Value="[ProgramFilesFolder]$(var.TestPrefix)Python [ShortVersion]" bal:Overridable="yes" />
+    <Variable Name="DefaultAllUsersTargetDir" Value="[ProgramFilesFolder]$(var.TestPrefix)Python[WinVerNoDot]" bal:Overridable="yes" />
     <Variable Name="TargetPlatform" Value="x86" />
     <?endif ?>
-    <Variable Name="DefaultJustForMeTargetDir" Value="[LocalAppDataFolder]Programs\$(var.TestPrefix)Python\Python[ShortVersionNoDot]$(var.Suffix32)" bal:Overridable="yes" />
-    <Variable Name="OptionalFeaturesRegistryKey" Value="Software\$(var.TestPrefix)Python\PythonCore\[ShortVersion]$(var.Suffix32)\InstalledFeatures" />
-    <Variable Name="TargetDirRegistryKey" Value="Software\$(var.TestPrefix)Python\PythonCore\[ShortVersion]$(var.Suffix32)\InstallPath" />
+    <Variable Name="DefaultJustForMeTargetDir" Value="[LocalAppDataFolder]Programs\$(var.TestPrefix)Python\Python[WinVerNoDot]" bal:Overridable="yes" />
+    <Variable Name="OptionalFeaturesRegistryKey" Value="Software\$(var.TestPrefix)Python\PythonCore\[WinVer]\InstalledFeatures" />
+    <Variable Name="TargetDirRegistryKey" Value="Software\$(var.TestPrefix)Python\PythonCore\[WinVer]\InstallPath" />
     
     <!--
     An empty string will use the other defaults based on InstallAllUsers
diff --git a/Tools/msi/bundle/packagegroups/packageinstall.wxs b/Tools/msi/bundle/packagegroups/packageinstall.wxs
--- a/Tools/msi/bundle/packagegroups/packageinstall.wxs
+++ b/Tools/msi/bundle/packagegroups/packageinstall.wxs
@@ -12,8 +12,8 @@
                         SourceFile="py.exe"
                         Compressed="yes"
                         DisplayName="!(loc.CompileAllDescription)"
-                        InstallCommand='-$(var.ShortVersion)$(var.Suffix32) -m pip install requests-2.7.0-py2.py3-none-any.whl'
-                        UninstallCommand='-$(var.ShortVersion)$(var.Suffix32) -m pip uninstall -y requests'
+                        InstallCommand='-[WinVer] -m pip install requests-2.7.0-py2.py3-none-any.whl'
+                        UninstallCommand='-[WinVer] -m pip uninstall -y requests'
                         Vital="no"
                         InstallCondition="Include_pip and not LauncherOnly">
                 <Payload SourceFile="requests-2.7.0-py2.py3-none-any.whl"
diff --git a/Tools/msi/bundle/packagegroups/postinstall.wxs b/Tools/msi/bundle/packagegroups/postinstall.wxs
--- a/Tools/msi/bundle/packagegroups/postinstall.wxs
+++ b/Tools/msi/bundle/packagegroups/postinstall.wxs
@@ -26,8 +26,8 @@
                         SourceFile="py.exe"
                         Compressed="yes"
                         DisplayName="!(loc.CompileAllDescription)"
-                        InstallCommand='-$(var.ShortVersion)$(var.Suffix32) $(var.CompileAllCommand)'
-                        RepairCommand='-$(var.ShortVersion)$(var.Suffix32) $(var.CompileAllCommand)'
+                        InstallCommand='-[WinVer] $(var.CompileAllCommand)'
+                        RepairCommand='-[WinVer] $(var.CompileAllCommand)'
                         Permanent="yes"
                         PerMachine="yes"
                         Vital="no"
@@ -36,8 +36,8 @@
                         SourceFile="py.exe"
                         Compressed="yes"
                         DisplayName="!(loc.CompileAllODescription)"
-                        InstallCommand='-$(var.ShortVersion)$(var.Suffix32) -O $(var.CompileAllCommand)'
-                        RepairCommand='-$(var.ShortVersion)$(var.Suffix32) -O $(var.CompileAllCommand)'
+                        InstallCommand='-[WinVer] -O $(var.CompileAllCommand)'
+                        RepairCommand='-[WinVer] -O $(var.CompileAllCommand)'
                         Permanent="yes"
                         PerMachine="yes"
                         Vital="no"
@@ -46,8 +46,8 @@
                         SourceFile="py.exe"
                         Compressed="yes"
                         DisplayName="!(loc.CompileAllOODescription)"
-                        InstallCommand='-$(var.ShortVersion)$(var.Suffix32) -OO $(var.CompileAllCommand)'
-                        RepairCommand='-$(var.ShortVersion)$(var.Suffix32) -OO $(var.CompileAllCommand)'
+                        InstallCommand='-[WinVer] -OO $(var.CompileAllCommand)'
+                        RepairCommand='-[WinVer] -OO $(var.CompileAllCommand)'
                         Permanent="yes"
                         PerMachine="yes"
                         Vital="no"
@@ -57,8 +57,8 @@
                         SourceFile="py.exe"
                         Compressed="yes"
                         DisplayName="!(loc.CompileAllDescription)"
-                        InstallCommand='-$(var.ShortVersion)$(var.Suffix32) $(var.CompileAllCommand)'
-                        RepairCommand='-$(var.ShortVersion)$(var.Suffix32) $(var.CompileAllCommand)'
+                        InstallCommand='-[WinVer] $(var.CompileAllCommand)'
+                        RepairCommand='-[WinVer] $(var.CompileAllCommand)'
                         Permanent="yes"
                         PerMachine="no"
                         Vital="no"
@@ -67,8 +67,8 @@
                         SourceFile="py.exe"
                         Compressed="yes"
                         DisplayName="!(loc.CompileAllODescription)"
-                        InstallCommand='-$(var.ShortVersion)$(var.Suffix32) -O $(var.CompileAllCommand)'
-                        RepairCommand='-$(var.ShortVersion)$(var.Suffix32) -O $(var.CompileAllCommand)'
+                        InstallCommand='-[WinVer] -O $(var.CompileAllCommand)'
+                        RepairCommand='-[WinVer] -O $(var.CompileAllCommand)'
                         Permanent="yes"
                         PerMachine="no"
                         Vital="no"
@@ -77,8 +77,8 @@
                         SourceFile="py.exe"
                         Compressed="yes"
                         DisplayName="!(loc.CompileAllOODescription)"
-                        InstallCommand='-$(var.ShortVersion)$(var.Suffix32) -OO $(var.CompileAllCommand)'
-                        RepairCommand='-$(var.ShortVersion)$(var.Suffix32) -OO $(var.CompileAllCommand)'
+                        InstallCommand='-[WinVer] -OO $(var.CompileAllCommand)'
+                        RepairCommand='-[WinVer] -OO $(var.CompileAllCommand)'
                         Permanent="yes"
                         PerMachine="no"
                         Vital="no"

-- 
Repository URL: https://hg.python.org/cpython