[Python-checkins] cpython (3.4): Issue #23576: Avoid stalling in SSL reads when EOF has been reached in the SSL
antoine.pitrou
python-checkins at python.org
Wed Mar 4 20:56:34 CET 2015
https://hg.python.org/cpython/rev/01cf9ce75eda
changeset: 94847:01cf9ce75eda
branch: 3.4
parent: 94844:4888f9498db6
user: Antoine Pitrou <solipsis at pitrou.net>
date: Wed Mar 04 20:51:55 2015 +0100
summary:
Issue #23576: Avoid stalling in SSL reads when EOF has been reached in the SSL layer but the underlying connection hasn't been closed.
files:
Misc/NEWS | 3 +++
Modules/_ssl.c | 20 --------------------
2 files changed, 3 insertions(+), 20 deletions(-)
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -13,6 +13,9 @@
Library
-------
+- Issue #23576: Avoid stalling in SSL reads when EOF has been reached in the
+ SSL layer but the underlying connection hasn't been closed.
+
- Issue #23504: Added an __all__ to the types module.
- Issue #20204: Added the __module__ attribute to _tkinter classes.
diff --git a/Modules/_ssl.c b/Modules/_ssl.c
--- a/Modules/_ssl.c
+++ b/Modules/_ssl.c
@@ -1717,26 +1717,6 @@
BIO_set_nbio(SSL_get_rbio(self->ssl), nonblocking);
BIO_set_nbio(SSL_get_wbio(self->ssl), nonblocking);
- /* first check if there are bytes ready to be read */
- PySSL_BEGIN_ALLOW_THREADS
- count = SSL_pending(self->ssl);
- PySSL_END_ALLOW_THREADS
-
- if (!count) {
- sockstate = check_socket_and_wait_for_timeout(sock, 0);
- if (sockstate == SOCKET_HAS_TIMED_OUT) {
- PyErr_SetString(PySocketModule.timeout_error,
- "The read operation timed out");
- goto error;
- } else if (sockstate == SOCKET_TOO_LARGE_FOR_SELECT) {
- PyErr_SetString(PySSLErrorObject,
- "Underlying socket too large for select().");
- goto error;
- } else if (sockstate == SOCKET_HAS_BEEN_CLOSED) {
- count = 0;
- goto done;
- }
- }
do {
PySSL_BEGIN_ALLOW_THREADS
count = SSL_read(self->ssl, mem, len);
--
Repository URL: https://hg.python.org/cpython
More information about the Python-checkins
mailing list