[Python-checkins] cpython (3.4): Issue #24678: Fixed raiseExceptions typo in logging tests.

serhiy.storchaka python-checkins at python.org
Tue Jul 21 21:41:59 CEST 2015


https://hg.python.org/cpython/rev/20e2b980bb87
changeset:   96979:20e2b980bb87
branch:      3.4
parent:      96967:0220328f962c
user:        Serhiy Storchaka <storchaka at gmail.com>
date:        Tue Jul 21 22:39:26 2015 +0300
summary:
  Issue #24678: Fixed raiseExceptions typo in logging tests.
Patch by Jacek Kołodziej.

files:
  Lib/test/test_logging.py |  17 ++++++-----------
  1 files changed, 6 insertions(+), 11 deletions(-)


diff --git a/Lib/test/test_logging.py b/Lib/test/test_logging.py
--- a/Lib/test/test_logging.py
+++ b/Lib/test/test_logging.py
@@ -41,7 +41,8 @@
 import tempfile
 from test.script_helper import assert_python_ok
 from test.support import (captured_stdout, run_with_locale, run_unittest,
-                          patch, requires_zlib, TestHandler, Matcher, HOST)
+                          patch, requires_zlib, TestHandler, Matcher, HOST,
+                          swap_attr)
 import textwrap
 import time
 import unittest
@@ -3748,18 +3749,12 @@
                          (exc.__class__, exc, exc.__traceback__))
 
     def test_log_invalid_level_with_raise(self):
-        old_raise = logging.raiseExceptions
-        self.addCleanup(setattr, logging, 'raiseExecptions', old_raise)
-
-        logging.raiseExceptions = True
-        self.assertRaises(TypeError, self.logger.log, '10', 'test message')
+        with swap_attr(logging, 'raiseExceptions', True):
+            self.assertRaises(TypeError, self.logger.log, '10', 'test message')
 
     def test_log_invalid_level_no_raise(self):
-        old_raise = logging.raiseExceptions
-        self.addCleanup(setattr, logging, 'raiseExecptions', old_raise)
-
-        logging.raiseExceptions = False
-        self.logger.log('10', 'test message')  # no exception happens
+        with swap_attr(logging, 'raiseExceptions', False):
+            self.logger.log('10', 'test message')  # no exception happens
 
     def test_find_caller_with_stack_info(self):
         called = []

-- 
Repository URL: https://hg.python.org/cpython


More information about the Python-checkins mailing list