[Python-checkins] cpython (3.4): fix merge_collapse to actually maintain the invariant it purports to (closes

[benjamin.peterson]

https://hg.python.org/cpython/rev/620cb13008b7
changeset:   94745:620cb13008b7
branch:      3.4
parent:      94742:14e7a28235c6
user:        Benjamin Peterson <benjamin at python.org>
date:        Wed Feb 25 10:12:26 2015 -0500
summary:
  fix merge_collapse to actually maintain the invariant it purports to (closes #23515)

See
de Gouw, Stijn and Rot, Jurriaan and de Boer, Frank S and Bubel, Richard and Hähnle, Reiner
"OpenJDK’s java.utils.Collection.sort() is broken: The good, the bad and the worst case"

files:
  Objects/listobject.c |  3 ++-
  1 files changed, 2 insertions(+), 1 deletions(-)


diff --git a/Objects/listobject.c b/Objects/listobject.c
--- a/Objects/listobject.c
+++ b/Objects/listobject.c
@@ -1832,7 +1832,8 @@
     assert(ms);
     while (ms->n > 1) {
         Py_ssize_t n = ms->n - 2;
-        if (n > 0 && p[n-1].len <= p[n].len + p[n+1].len) {
+        if ((n > 0 && p[n-1].len <= p[n].len + p[n+1].len) ||
+            (n > 1 && p[n-2].len <= p[n-1].len + p[n].len)) {
             if (p[n-1].len < p[n+1].len)
                 --n;
             if (merge_at(ms, n) < 0)

-- 
Repository URL: https://hg.python.org/cpython