[Python-checkins] cpython: Issue #21932: Skip test_os.test_large_read() on 32-bit system

victor.stinner python-checkins at python.org
Sat Jul 12 11:04:59 CEST 2014


http://hg.python.org/cpython/rev/880e2cdac8b1
changeset:   91659:880e2cdac8b1
user:        Victor Stinner <victor.stinner at gmail.com>
date:        Sat Jul 12 11:03:53 2014 +0200
summary:
  Issue #21932: Skip test_os.test_large_read() on 32-bit system

files:
  Lib/test/test_os.py |  8 ++++++--
  1 files changed, 6 insertions(+), 2 deletions(-)


diff --git a/Lib/test/test_os.py b/Lib/test/test_os.py
--- a/Lib/test/test_os.py
+++ b/Lib/test/test_os.py
@@ -44,9 +44,9 @@
 except ImportError:
     _winapi = None
 try:
-    from _testcapi import INT_MAX
+    from _testcapi import INT_MAX, PY_SSIZE_T_MAX
 except ImportError:
-    INT_MAX = 2 ** 31 - 1
+    INT_MAX = PY_SSIZE_T_MAX = sys.maxsize
 
 from test.script_helper import assert_python_ok
 
@@ -124,6 +124,10 @@
             self.assertEqual(s, b"spam")
 
     @support.cpython_only
+    # Skip the test on 32-bit platforms: the number of bytes must fit in a
+    # Py_ssize_t type
+    @unittest.skipUnless(INT_MAX < PY_SSIZE_T_MAX,
+                         "needs INT_MAX < PY_SSIZE_T_MAX")
     @support.bigmemtest(size=INT_MAX + 10, memuse=1, dry_run=False)
     def test_large_read(self, size):
         with open(support.TESTFN, "wb") as fp:

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list