[Python-checkins] cpython: Issue #21907: Avoid using double quotes to check argument values.

[zach.ware]

http://hg.python.org/cpython/rev/4c1d543135ef
changeset:   91952:4c1d543135ef
user:        Zachary Ware <zachary.ware at gmail.com>
date:        Thu Jul 31 23:58:27 2014 -0500
summary:
  Issue #21907: Avoid using double quotes to check argument values.

Double quotes in expanded variables can match literal double quotes,
which makes for a big mess when passing in a quoted argument (like
"/p:externalsDir=..\externals", for example).

files:
  PCbuild/build.bat |  12 ++++++------
  1 files changed, 6 insertions(+), 6 deletions(-)


diff --git a/PCbuild/build.bat b/PCbuild/build.bat
--- a/PCbuild/build.bat
+++ b/PCbuild/build.bat
@@ -16,13 +16,13 @@
 set dir=%~dp0
 
 :CheckOpts
-if "%1"=="-c" (set conf=%2) & shift & shift & goto CheckOpts
-if "%1"=="-p" (set platf=%2) & shift & shift & goto CheckOpts
-if "%1"=="-r" (set target=Rebuild) & shift & goto CheckOpts
-if "%1"=="-d" (set conf=Debug) & shift & goto CheckOpts
-if "%1"=="-e" call "%dir%get_externals.bat" & shift & goto CheckOpts
+if '%1'=='-c' (set conf=%2) & shift & shift & goto CheckOpts
+if '%1'=='-p' (set platf=%2) & shift & shift & goto CheckOpts
+if '%1'=='-r' (set target=Rebuild) & shift & goto CheckOpts
+if '%1'=='-d' (set conf=Debug) & shift & goto CheckOpts
+if '%1'=='-e' call "%dir%get_externals.bat" & shift & goto CheckOpts
 
-if "%platf%"=="x64" (set vs_platf=x86_amd64)
+if '%platf%'=='x64' (set vs_platf=x86_amd64)
 
 rem Setup the environment
 call "%VS100COMNTOOLS%..\..\VC\vcvarsall.bat" %vs_platf%

-- 
Repository URL: http://hg.python.org/cpython