[Python-checkins] cpython (3.3): Issue #19112: avoid using function defined in method.

richard.oudkerk python-checkins at python.org
Sun Sep 29 18:34:36 CEST 2013


http://hg.python.org/cpython/rev/74752bfa6357
changeset:   85851:74752bfa6357
branch:      3.3
parent:      85847:b76e1b58ed45
user:        Richard Oudkerk <shibturn at gmail.com>
date:        Sun Sep 29 17:29:56 2013 +0100
summary:
  Issue #19112: avoid using function defined in method.

files:
  Lib/test/test_multiprocessing.py |  17 +++++++++--------
  1 files changed, 9 insertions(+), 8 deletions(-)


diff --git a/Lib/test/test_multiprocessing.py b/Lib/test/test_multiprocessing.py
--- a/Lib/test/test_multiprocessing.py
+++ b/Lib/test/test_multiprocessing.py
@@ -3117,12 +3117,19 @@
 # Verifies os.close(sys.stdin.fileno) vs. sys.stdin.close() behavior
 #
 
-def _ThisSubProcess(q):
+def _this_sub_process(q):
     try:
         item = q.get(block=False)
     except pyqueue.Empty:
         pass
 
+def _test_process(q):
+    queue = multiprocessing.Queue()
+    subProc = multiprocessing.Process(target=_this_sub_process, args=(queue,))
+    subProc.daemon = True
+    subProc.start()
+    subProc.join()
+
 def _afunc(x):
     return x*x
 
@@ -3156,14 +3163,8 @@
 class TestStdinBadfiledescriptor(unittest.TestCase):
 
     def test_queue_in_process(self):
-        def _TestProcess(q):
-            queue = multiprocessing.Queue()
-            subProc = multiprocessing.Process(target=_ThisSubProcess, args=(queue,))
-            subProc.daemon = True
-            subProc.start()
-            subProc.join()
         queue = multiprocessing.Queue()
-        proc = multiprocessing.Process(target=_TestProcess, args=(queue,))
+        proc = multiprocessing.Process(target=_test_process, args=(queue,))
         proc.start()
         proc.join()
 

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list