[Python-checkins] cpython (3.3): just return toplevel symbol table rather than all blocks (closes #19393)

[benjamin.peterson]

http://hg.python.org/cpython/rev/bc259b221cb8
changeset:   86660:bc259b221cb8
branch:      3.3
parent:      86653:150242784de0
user:        Benjamin Peterson <benjamin at python.org>
date:        Sat Oct 26 13:13:51 2013 -0400
summary:
  just return toplevel symbol table rather than all blocks (closes #19393)

files:
  Lib/symtable.py          |  5 +----
  Misc/NEWS                |  3 +++
  Modules/symtablemodule.c |  2 +-
  3 files changed, 5 insertions(+), 5 deletions(-)


diff --git a/Lib/symtable.py b/Lib/symtable.py
--- a/Lib/symtable.py
+++ b/Lib/symtable.py
@@ -10,10 +10,7 @@
 __all__ = ["symtable", "SymbolTable", "Class", "Function", "Symbol"]
 
 def symtable(code, filename, compile_type):
-    raw = _symtable.symtable(code, filename, compile_type)
-    for top in raw.values():
-        if top.name == 'top':
-            break
+    top = _symtable.symtable(code, filename, compile_type)
     return _newSymbolTable(top, filename)
 
 class SymbolTableFactory:
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -81,6 +81,9 @@
 Library
 -------
 
+- Issue #19393: Fix symtable.symtable function to not be confused when there are
+  functions or classes named "top".
+
 - Issue #19339: telnetlib module is now using time.monotonic() when available
   to compute timeout.
 
diff --git a/Modules/symtablemodule.c b/Modules/symtablemodule.c
--- a/Modules/symtablemodule.c
+++ b/Modules/symtablemodule.c
@@ -32,7 +32,7 @@
     st = Py_SymtableString(str, filename, start);
     if (st == NULL)
         return NULL;
-    t = st->st_blocks;
+    t = (PyObject *)st->st_top;
     Py_INCREF(t);
     PyMem_Free((void *)st->st_future);
     PySymtable_Free(st);

-- 
Repository URL: http://hg.python.org/cpython