[Python-checkins] cpython (3.3): Fix macro expansion of _PyErr_OCCURRED(), and make sure to use it in at least
antoine.pitrou
python-checkins at python.org
Mon Oct 7 20:41:31 CEST 2013
http://hg.python.org/cpython/rev/2aee9c41bb79
changeset: 86140:2aee9c41bb79
branch: 3.3
parent: 86136:b4444d16e333
user: Antoine Pitrou <solipsis at pitrou.net>
date: Mon Oct 07 20:38:51 2013 +0200
summary:
Fix macro expansion of _PyErr_OCCURRED(), and make sure to use it in at least one place so as to avoid regressions.
files:
Include/pyerrors.h | 2 +-
Misc/NEWS | 3 +++
Python/ceval.c | 4 ++--
3 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/Include/pyerrors.h b/Include/pyerrors.h
--- a/Include/pyerrors.h
+++ b/Include/pyerrors.h
@@ -100,7 +100,7 @@
#if defined(Py_DEBUG) || defined(Py_LIMITED_API)
#define _PyErr_OCCURRED() PyErr_Occurred()
#else
-#define _PyErr_OCCURRED() (_PyThreadState_Current->curexc_type)
+#define _PyErr_OCCURRED() (PyThreadState_GET()->curexc_type)
#endif
/* Error testing and normalization */
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -12,6 +12,9 @@
Core and Builtins
-----------------
+- Fix macro expansion of _PyErr_OCCURRED(), and make sure to use it in at
+ least one place so as to avoid regressions.
+
- Issue #19014: memoryview.cast() is now allowed on zero-length views.
- Issue #19098: Prevent overflow in the compiler when the recursion limit is set
diff --git a/Python/ceval.c b/Python/ceval.c
--- a/Python/ceval.c
+++ b/Python/ceval.c
@@ -2083,7 +2083,7 @@
}
else {
x = PyObject_GetItem(v, w);
- if (x == NULL && PyErr_Occurred()) {
+ if (x == NULL && _PyErr_OCCURRED()) {
if (!PyErr_ExceptionMatches(
PyExc_KeyError))
break;
@@ -2127,7 +2127,7 @@
(PyDictObject *)f->f_builtins,
w);
if (x == NULL) {
- if (!PyErr_Occurred())
+ if (!_PyErr_OCCURRED())
format_exc_check_arg(PyExc_NameError,
GLOBAL_NAME_ERROR_MSG, w);
break;
--
Repository URL: http://hg.python.org/cpython
More information about the Python-checkins
mailing list